Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 201673005: Revert 169577 "[HTML Import] Let script block by pending resourc..." (Closed)

Created:
6 years, 9 months ago by Hajime Morrita
Modified:
6 years, 9 months ago
Reviewers:
Hajime Morrita
CC:
blink-reviews
Visibility:
Public.

Description

Revert 169577 "[HTML Import] Let script block by pending resourc..." This is a speculative revert to address reported crashes in the wild. > [HTML Import] Let script block by pending resources created by lifecycle callback > > This change tells the HTML parser know that lifecycle callbacks, > that is triggered through Microtask checkpoint, can create resources that > blocks scripts. > > It also streamlines the unblock notification from Document to the parser > into didLoadAllScriptBlockingResources(). Now both didRemoveAllPendingStylesheets() > and didLoadAllImports() checks resource readiness and invokes the unified notification. > > TEST=custom-element-style-block.html > BUG=346408 > R=dglazkov@chromium.org, dominicc@chromium.org > > Review URL: https://codereview.chromium.org/202813002 TBR=morrita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -61 lines) Patch
D trunk/LayoutTests/fast/html/imports/custom-element-style-block.html View 1 chunk +0 lines, -18 lines 0 comments Download
D trunk/LayoutTests/fast/html/imports/resources/custom-element-style.html View 1 chunk +0 lines, -16 lines 0 comments Download
M trunk/Source/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/dom/Document.cpp View 2 chunks +8 lines, -20 lines 0 comments Download
M trunk/Source/core/html/imports/HTMLImportsController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/html/parser/HTMLScriptRunner.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hajime Morrita
6 years, 9 months ago (2014-03-21 20:55:44 UTC) #1
Hajime Morrita
6 years, 9 months ago (2014-03-21 20:56:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r169769.

Powered by Google App Engine
This is Rietveld 408576698