Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 202813002: [HTML Import] Let script block by pending resources created by lifecycle callback (Closed)

Created:
6 years, 9 months ago by Hajime Morrita
Modified:
6 years, 9 months ago
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

[HTML Import] Let script block by pending resources created by lifecycle callback This change tells the HTML parser know that lifecycle callbacks, that is triggered through Microtask checkpoint, can create resources that blocks scripts. It also streamlines the unblock notification from Document to the parser into didLoadAllScriptBlockingResources(). Now both didRemoveAllPendingStylesheets() and didLoadAllImports() checks resource readiness and invokes the unified notification. TEST=custom-element-style-block.html BUG=346408 R=dglazkov@chromium.org, dominicc@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169577 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169782

Patch Set 1 #

Patch Set 2 : Landing #

Total comments: 1

Patch Set 3 : Added assert_true() :-/ #

Patch Set 4 : Updated to ToT. #

Patch Set 5 : Re-landing with another fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -13 lines) Patch
A LayoutTests/fast/html/imports/custom-element-style-block.html View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/html/imports/resources/custom-element-style.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/parser/defer-style-crash.html View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
A + LayoutTests/fast/parser/defer-style-crash-expected.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/fast/parser/resources/hello.css View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/parser/resources/hello.js View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 2 chunks +20 lines, -8 lines 0 comments Download
M Source/core/html/imports/HTMLImportsController.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.h View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.cpp View 1 2 3 4 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 40 (0 generated)
Hajime Morrita
PTAL?
6 years, 9 months ago (2014-03-18 00:11:16 UTC) #1
dglazkov
lgtm
6 years, 9 months ago (2014-03-18 18:17:45 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-18 18:32:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/202813002/1
6 years, 9 months ago (2014-03-18 18:32:14 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 19:35:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-18 19:35:25 UTC) #6
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-18 23:09:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/202813002/20001
6 years, 9 months ago (2014-03-18 23:10:06 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 23:13:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-18 23:13:45 UTC) #10
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-18 23:17:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/202813002/20001
6 years, 9 months ago (2014-03-18 23:17:50 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 23:21:07 UTC) #13
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-18 23:21:08 UTC) #14
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-18 23:25:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/202813002/20001
6 years, 9 months ago (2014-03-18 23:25:29 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 23:51:41 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-18 23:51:42 UTC) #18
dominicc (has gone to gerrit)
DBC, just curious about this. https://codereview.chromium.org/202813002/diff/20001/LayoutTests/fast/html/imports/custom-element-style-block.html File LayoutTests/fast/html/imports/custom-element-style-block.html (right): https://codereview.chromium.org/202813002/diff/20001/LayoutTests/fast/html/imports/custom-element-style-block.html#newcode11 LayoutTests/fast/html/imports/custom-element-style-block.html:11: test(function(){ This test appears ...
6 years, 9 months ago (2014-03-18 23:55:27 UTC) #19
Hajime Morrita
On 2014/03/18 23:55:27, dominicc wrote: > DBC, just curious about this. > > https://codereview.chromium.org/202813002/diff/20001/LayoutTests/fast/html/imports/custom-element-style-block.html > ...
6 years, 9 months ago (2014-03-19 00:01:56 UTC) #20
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-19 00:14:46 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/202813002/40001
6 years, 9 months ago (2014-03-19 00:14:54 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 01:55:06 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-19 01:55:06 UTC) #24
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-19 19:08:21 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/202813002/60001
6 years, 9 months ago (2014-03-19 19:08:25 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 19:10:47 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-19 19:10:48 UTC) #28
Hajime Morrita
Committed patchset #4 manually as r169577 (presubmit successful).
6 years, 9 months ago (2014-03-19 20:05:54 UTC) #29
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-21 23:04:51 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/202813002/80001
6 years, 9 months ago (2014-03-21 23:05:00 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 23:07:22 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-21 23:07:23 UTC) #33
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-21 23:08:25 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/202813002/80001
6 years, 9 months ago (2014-03-21 23:08:32 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 00:01:14 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-22 00:01:15 UTC) #37
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 9 months ago (2014-03-22 00:22:17 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/202813002/80001
6 years, 9 months ago (2014-03-22 00:22:27 UTC) #39
commit-bot: I haz the power
6 years, 9 months ago (2014-03-22 04:24:51 UTC) #40
Message was sent while issue was closed.
Change committed as 169782

Powered by Google App Engine
This is Rietveld 408576698