AudioParam.setValueCurveAtTime() should copy the curve data

AudioParam.setValueCurveAtTime() should copy the curve data

setValueCurveAtTime() should copy the curve data so that modifications
of the original array don't change what setValueCurveAtTime would
produce.

See description of value parameter at http://webaudio.github.io/web-audio-api/#widl-AudioParam-setValueCurveAtTime-AudioParam-Float32Array-values-double-startTime-double-duration

BUG=582980
TEST=audioparam-setValueCurve-copy.html

Committed: https://crrev.com/7430a77312e7279e63aa9c0c3ba244b819202192
Cr-Commit-Position: refs/heads/master@{#397161}

[Raymond Toy, 2016-05-26 15:47:54]

Description was changed from

==========
AudioParam.setValueCurveAtTime() should copy the curve data

setValueCurveAtTime() should copy the curve data so that modifications
of the original array don't change what setValueCurveAtTime would
produce.

BUG=582980
TEST=audioparam-setValueCurve-copy.html
==========

to

==========
AudioParam.setValueCurveAtTime() should copy the curve data

setValueCurveAtTime() should copy the curve data so that modifications
of the original array don't change what setValueCurveAtTime would
produce.

See description of value parameter at
http://webaudio.github.io/web-audio-api/#widl-AudioParam-setValueCurveAtTime-...

BUG=582980
TEST=audioparam-setValueCurve-copy.html
==========

[Raymond Toy, 2016-05-26 15:48:19]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-05-26 15:48:19]

PTAL

[Raymond Toy, 2016-05-31 21:37:52]

On 2016/05/26 15:48:19, Raymond Toy wrote:
> PTAL

Ping

[hongchan, 2016-05-31 21:42:33]

lgtm with nits.

https://codereview.chromium.org/2016563002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-copy.html
(right):

https://codereview.chromium.org/2016563002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-copy.html:36: 
nit: can we remove this blank line?

https://codereview.chromium.org/2016563002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-copy.html:42:
// The actual curve data can be anything, but we use this for simplicity.
Let's wrap the comment at 80 cols.

https://codereview.chromium.org/2016563002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h (right):

https://codereview.chromium.org/2016563002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h:109:
Vector<float> m_curve;
DId this happen in rebasing? Just curious how this change is possible.

[Raymond Toy, 2016-05-31 22:20:04]

https://codereview.chromium.org/2016563002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h (right):

https://codereview.chromium.org/2016563002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h:109:
Vector<float> m_curve;
On 2016/05/31 21:42:33, hoch wrote:
> DId this happen in rebasing? Just curious how this change is possible.

I'm copying the DOMFloat32Array that is given to this new internal array. This
array no longer has any connection to the original DOM array.

[Raymond Toy, 2016-05-31 22:50:51]

https://codereview.chromium.org/2016563002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-copy.html
(right):

https://codereview.chromium.org/2016563002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-copy.html:36: 
On 2016/05/31 21:42:33, hoch wrote:
> nit: can we remove this blank line?

Done.

https://codereview.chromium.org/2016563002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audioparam-setValueCurve-copy.html:42:
// The actual curve data can be anything, but we use this for simplicity.
On 2016/05/31 21:42:33, hoch wrote:
> Let's wrap the comment at 80 cols.

Done.

[Raymond Toy, 2016-06-01 15:10:02]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-06-01 15:10:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2016563002/#ps60001
(title: "Address review comments")

[commit-bot: I haz the power, 2016-06-01 15:10:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2016563002/60001

[commit-bot: I haz the power, 2016-06-01 16:52:28]

Description was changed from

==========
AudioParam.setValueCurveAtTime() should copy the curve data

setValueCurveAtTime() should copy the curve data so that modifications
of the original array don't change what setValueCurveAtTime would
produce.

See description of value parameter at
http://webaudio.github.io/web-audio-api/#widl-AudioParam-setValueCurveAtTime-...

BUG=582980
TEST=audioparam-setValueCurve-copy.html
==========

to

==========
AudioParam.setValueCurveAtTime() should copy the curve data

setValueCurveAtTime() should copy the curve data so that modifications
of the original array don't change what setValueCurveAtTime would
produce.

See description of value parameter at
http://webaudio.github.io/web-audio-api/#widl-AudioParam-setValueCurveAtTime-...

BUG=582980
TEST=audioparam-setValueCurve-copy.html
==========

[commit-bot: I haz the power, 2016-06-01 16:52:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-01 16:54:01]

Description was changed from

==========
AudioParam.setValueCurveAtTime() should copy the curve data

setValueCurveAtTime() should copy the curve data so that modifications
of the original array don't change what setValueCurveAtTime would
produce.

See description of value parameter at
http://webaudio.github.io/web-audio-api/#widl-AudioParam-setValueCurveAtTime-...

BUG=582980
TEST=audioparam-setValueCurve-copy.html
==========

to

==========
AudioParam.setValueCurveAtTime() should copy the curve data

setValueCurveAtTime() should copy the curve data so that modifications
of the original array don't change what setValueCurveAtTime would
produce.

See description of value parameter at
http://webaudio.github.io/web-audio-api/#widl-AudioParam-setValueCurveAtTime-...

BUG=582980
TEST=audioparam-setValueCurve-copy.html

Committed: https://crrev.com/7430a77312e7279e63aa9c0c3ba244b819202192
Cr-Commit-Position: refs/heads/master@{#397161}
==========

[commit-bot: I haz the power, 2016-06-01 16:54:02]

Patchset 4 (id:??) landed as
https://crrev.com/7430a77312e7279e63aa9c0c3ba244b819202192
Cr-Commit-Position: refs/heads/master@{#397161}