AudioParam.setValueCurveAtTime() should copy the curve data

third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 91 matching lines @@
         args = "..., " + String::number(event.time(), 16) + ", " + String::number(event.duration(), 16);
         break;
     case ParamEvent::LastType:
         ASSERT_NOT_REACHED();
         break;
     };
 
     return s + "(" + args + ")";
 }
 
+AudioParamTimeline::ParamEvent::ParamEvent(
+    Type type, float value, double time,
+    double timeConstant, double duration, const DOMFloat32Array* curve,
+    float initialValue, double callTime)
+    : m_type(type)
+    , m_value(value)
+    , m_time(time)
+    , m_timeConstant(timeConstant)
+    , m_duration(duration)
+    , m_initialValue(initialValue)
+    , m_callTime(callTime)
+{
+    if (curve) {
+        // Copy the curve data
+        unsigned curveLength = curve->length();
+        m_curve.resize(curveLength);
+        memcpy(m_curve.data(), curve->data(), curveLength * sizeof(float));
+    }
+}
+
 AudioParamTimeline::ParamEvent AudioParamTimeline::ParamEvent::createSetValueEvent(float value, double time)
 {
     return ParamEvent(ParamEvent::SetValue, value, time, 0, 0, nullptr);
 }
 
 AudioParamTimeline::ParamEvent AudioParamTimeline::ParamEvent::createLinearRampEvent(float value, double time, float initialValue, double callTime)
 {
     return ParamEvent(ParamEvent::LinearRampToValue, value, time, 0, 0, nullptr, initialValue, callTime);
 }
 
 AudioParamTimeline::ParamEvent AudioParamTimeline::ParamEvent::createExponentialRampEvent(float value, double time, float initialValue, double callTime)
 {
     return ParamEvent(ParamEvent::ExponentialRampToValue, value, time, 0, 0, nullptr, initialValue, callTime);
 }
 
 AudioParamTimeline::ParamEvent AudioParamTimeline::ParamEvent::createSetTargetEvent(float value, double time, double timeConstant)
 {
     return ParamEvent(ParamEvent::SetTarget, value, time, timeConstant, 0, nullptr);
 }
 
-AudioParamTimeline::ParamEvent AudioParamTimeline::ParamEvent::createSetValueCurveEvent(DOMFloat32Array* curve, double time, double duration)
+AudioParamTimeline::ParamEvent AudioParamTimeline::ParamEvent::createSetValueCurveEvent(const DOMFloat32Array* curve, double time, double duration)
 {
     return ParamEvent(ParamEvent::SetValueCurve, 0, time, 0, duration, curve);
 }
 
 void AudioParamTimeline::setValueAtTime(float value, double time, ExceptionState& exceptionState)
 {
     ASSERT(isMainThread());
 
     if (!isNonNegativeAudioParamTime(time, exceptionState))
         return;
@@ skipping 549 matching lines @@
                         // the last computed value.
                         if (writeIndex >= 1)
                             value = values[writeIndex - 1];
                         currentFrame = fillToEndFrame;
                     }
                     break;
                 }
 
             case ParamEvent::SetValueCurve:
                 {
-                    DOMFloat32Array* curve = event.curve();
-                    float* curveData = curve ? curve->data() : 0;
-                    unsigned numberOfCurvePoints = curve ? curve->length() : 0;
+                    Vector<float> curve = event.curve();
+                    float* curveData = curve.data();
+                    unsigned numberOfCurvePoints = curve.size();
 
                     // Curve events have duration, so don't just use next event time.
                     double duration = event.duration();
                     // How much to step the curve index for each frame.  This is basically the term
                     // (N - 1)/Td in the specification.
                     double curvePointsPerFrame = (numberOfCurvePoints - 1) / duration / sampleRate;
 
-                    if (!curve || !curveData || !numberOfCurvePoints || duration <= 0 || sampleRate <= 0) {
+                    if (!numberOfCurvePoints || duration <= 0 || sampleRate <= 0) {
                         // Error condition - simply propagate previous value.
                         currentFrame = fillToEndFrame;
                         for (; writeIndex < fillToFrame; ++writeIndex)
                             values[writeIndex] = value;
                         break;
                     }
 
                     // Save old values and recalculate information based on the curve's duration
                     // instead of the next event time.
                     size_t nextEventFillToFrame = fillToFrame;
@@ skipping 133 matching lines @@
     for (; writeIndex < numberOfValues; ++writeIndex)
         values[writeIndex] = value;
 
     // This value is used to set the .value attribute of the AudioParam.  it should be the last
     // computed value.
     return values[numberOfValues - 1];
 }
 
 } // namespace blink