Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2016463003: [sync] DCHECK from UTF16ToASCII from TemplateURLService (Closed)

Created:
4 years, 7 months ago by Patrick Noland
Modified:
4 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, Nicolas Zea, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sync] DCHECK from UTF16ToASCII from TemplateURLService LogDuplicatesHistogram erroneously assumes that all keywords are ASCII. This CL removes that assumption and adds a test for the crash. R=pkasting@chromium.org BUG=613082 Committed: https://crrev.com/122369ab8e771215d1afca236a20d16002c5000b Cr-Commit-Position: refs/heads/master@{#396876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M components/search_engines/template_url_service.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Patrick Noland
4 years, 7 months ago (2016-05-26 16:50:35 UTC) #2
Peter Kasting
LGTM
4 years, 7 months ago (2016-05-27 00:04:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016463003/1
4 years, 6 months ago (2016-05-31 17:12:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 18:43:43 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 18:45:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/122369ab8e771215d1afca236a20d16002c5000b
Cr-Commit-Position: refs/heads/master@{#396876}

Powered by Google App Engine
This is Rietveld 408576698