Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2111)

Unified Diff: chrome/browser/search_engines/template_url_service_sync_unittest.cc

Issue 2016463003: [sync] DCHECK from UTF16ToASCII from TemplateURLService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/search_engines/template_url_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/template_url_service_sync_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_service_sync_unittest.cc b/chrome/browser/search_engines/template_url_service_sync_unittest.cc
index 35908109a7dc725748003ccca1ad6865853e8958..ca3904c163a4ecf0693fb2a13a0ef0769f64f318 100644
--- a/chrome/browser/search_engines/template_url_service_sync_unittest.cc
+++ b/chrome/browser/search_engines/template_url_service_sync_unittest.cc
@@ -2272,3 +2272,13 @@ TEST_F(TemplateURLServiceSyncTest, GUIDUpdatedOnDefaultSearchChange) {
EXPECT_EQ(kNewGUID, profile_a()->GetTestingPrefService()->GetString(
prefs::kSyncedDefaultSearchProviderGUID));
}
+
+TEST_F(TemplateURLServiceSyncTest, NonAsciiKeywordDoesNotCrash) {
+ model()->Add(CreateTestTemplateURL(UTF8ToUTF16("\xf0\xaf\xa6\x8d"),
+ "http://key1.com"));
+ syncer::SyncDataList initial_data = CreateInitialSyncData();
+
+ model()->MergeDataAndStartSyncing(
+ syncer::SEARCH_ENGINES, initial_data, PassProcessor(),
+ CreateAndPassSyncErrorFactory());
+}
« no previous file with comments | « no previous file | components/search_engines/template_url_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698