Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2016403002: [chromedriver] Don't add frame id from Page.navigate to pending frame set. (Closed)

Created:
4 years, 6 months ago by samuong
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Don't add frame id from Page.navigate to pending frame set. BUG=chromedriver:1387 TBR=stgao@chromium.org Committed: https://crrev.com/aaeb88a4b3cd866494fe818dac7dc653bf664b44 Cr-Commit-Position: refs/heads/master@{#396946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M chrome/test/chromedriver/chrome/navigation_tracker.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016403002/1
4 years, 6 months ago (2016-05-27 17:04:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016403002/1
4 years, 6 months ago (2016-05-31 20:51:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 22:12:45 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 22:13:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaeb88a4b3cd866494fe818dac7dc653bf664b44
Cr-Commit-Position: refs/heads/master@{#396946}

Powered by Google App Engine
This is Rietveld 408576698