Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8974)

Unified Diff: chrome/test/chromedriver/chrome/navigation_tracker.cc

Issue 2016403002: [chromedriver] Don't add frame id from Page.navigate to pending frame set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/navigation_tracker.cc
diff --git a/chrome/test/chromedriver/chrome/navigation_tracker.cc b/chrome/test/chromedriver/chrome/navigation_tracker.cc
index 5250b70b74c16ab4d09ce4043f3ff0a63b4819c1..ae2dd00351c3b0e8370a134b0d84d6005c01b4f8 100644
--- a/chrome/test/chromedriver/chrome/navigation_tracker.cc
+++ b/chrome/test/chromedriver/chrome/navigation_tracker.cc
@@ -364,21 +364,6 @@ Status NavigationTracker::OnCommandSuccess(
DevToolsClient* client,
const std::string& method,
const base::DictionaryValue& result) {
- if (!IsExpectingFrameLoadingEvents()) {
- if (method == "Page.navigate" && loading_state_ == kLoading) {
- // In all versions of Chrome that are supported by ChromeDriver, except
- // for old versions of Android WebView, Page.navigate will return a
- // frameId in the command response. We'll get a notification that the
- // frame has loaded when we get the Page.frameStoppedLoading event, so
- // keep track of the pending frame id here.
- std::string pending_frame_id;
- if (result.GetString("frameId", &pending_frame_id)) {
- pending_frame_set_.insert(pending_frame_id);
- return Status(kOk);
- }
- }
- }
-
if ((method == "Page.navigate" || method == "Page.navigateToHistoryEntry") &&
loading_state_ != kLoading) {
// At this point the browser has initiated the navigation, but besides that,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698