Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2016363003: Revert of Avoid nesting steps called under waiting for x: (Closed)

Created:
4 years, 6 months ago by RobertoCN
Modified:
4 years, 6 months ago
Reviewers:
prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Avoid nesting steps called under waiting for x: (patchset #1 id:1 of https://codereview.chromium.org/2013133002/ ) Reason for revert: Broke downstream expectations. https://bugs.chromium.org/p/chromium/issues/detail?id=615463 Original issue's description: > Avoid nesting steps called under waiting for x: > > R=prasadv > BUG=602839 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/401e4870781011473779383953a9ef82792bda08 TBR=prasadv@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602839 Committed: https://chromium.googlesource.com/chromium/tools/build/+/533e49fdb5f66a0b4bc18dd819491fe47cd19cd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1831 lines, -1073 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/bisector.py View 1 chunk +14 lines, -13 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.py View 3 chunks +18 lines, -15 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json View 22 chunks +120 lines, -45 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json View 22 chunks +120 lines, -45 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json View 22 chunks +120 lines, -45 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json View 22 chunks +110 lines, -35 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json View 4 chunks +171 lines, -229 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json View 4 chunks +84 lines, -108 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json View 18 chunks +114 lines, -30 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json View 22 chunks +120 lines, -45 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json View 11 chunks +73 lines, -19 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json View 22 chunks +120 lines, -45 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json View 22 chunks +120 lines, -45 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json View 22 chunks +120 lines, -45 lines 0 comments Download
M scripts/slave/recipes/bisect.py View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisect.expected/basic.json View 28 chunks +131 lines, -103 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic_return_code_test.json View 24 chunks +123 lines, -95 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json View 12 chunks +75 lines, -55 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_good_revision_test.json View 12 chunks +75 lines, -55 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
RobertoCN
Created Revert of Avoid nesting steps called under waiting for x:
4 years, 6 months ago (2016-05-27 18:26:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016363003/1
4 years, 6 months ago (2016-05-27 18:26:39 UTC) #2
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 18:26:52 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/533e49fdb5f66a0b4bc1...

Powered by Google App Engine
This is Rietveld 408576698