Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 2016363003: Revert of Avoid nesting steps called under waiting for x: (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/example.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/bisector.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector.py b/scripts/slave/recipe_modules/auto_bisect/bisector.py
index 8d8a48f6b531146ca45f7bed6599b887adfcfa19..82b452b91efc5648e28ff6c91e7345b5848128ee 100644
--- a/scripts/slave/recipe_modules/auto_bisect/bisector.py
+++ b/scripts/slave/recipe_modules/auto_bisect/bisector.py
@@ -744,19 +744,20 @@
def wait_for(self, revision):
"""Waits for the revision to finish its job."""
- while True:
- revision.update_status()
- if revision.in_progress:
- self.api.m.python.inline(
- 'sleeping',
- """
- import sys
- import time
- time.sleep(20*60)
- sys.exit(0)
- """)
- else:
- break
+ with self.api.m.step.nest('Waiting for ' + revision.revision_string()):
+ while True:
+ revision.update_status()
+ if revision.in_progress:
+ self.api.m.python.inline(
+ 'sleeping',
+ """
+ import sys
+ import time
+ time.sleep(20*60)
+ sys.exit(0)
+ """)
+ else:
+ break
def _update_candidate_range(self):
"""Updates lkgr and fkbr (last known good/first known bad) revisions.
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698