Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2016343002: Revert of Add drawer with state information (Closed)

Created:
4 years, 6 months ago by kjlubick
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add drawer with state information (patchset #8 id:140001 of https://codereview.chromium.org/2004633002/ ) Reason for revert: Broke Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan. See https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan/builds/134/steps/compile_skia%20on%20Ubuntu/logs/stdio. Original issue's description: > Now we can use drawer to view the state information of the native app, and set its state using the spinner. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002 > > Committed: https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec TBR=djsollen@google.com,jvanverth@google.com,liyuqian@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9ad094933817800a2f700d261909000aca762fbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -399 lines) Patch
M platform_tools/android/apps/viewer/build.gradle View 1 chunk +1 line, -7 lines 0 comments Download
D platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/StateAdapter.java View 1 chunk +0 lines, -114 lines 0 comments Download
M platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerActivity.java View 6 chunks +4 lines, -50 lines 0 comments Download
M platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerApplication.java View 2 chunks +3 lines, -28 lines 0 comments Download
M platform_tools/android/apps/viewer/src/main/res/layout/activity_main.xml View 1 chunk +12 lines, -31 lines 0 comments Download
D platform_tools/android/apps/viewer/src/main/res/layout/state_item.xml View 1 chunk +0 lines, -35 lines 0 comments Download
D platform_tools/android/apps/viewer/src/main/res/values/strings.xml View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/viewer/Viewer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/viewer/Viewer.cpp View 6 chunks +0 lines, -64 lines 0 comments Download
M tools/viewer/sk_app/Window.h View 5 chunks +0 lines, -13 lines 0 comments Download
M tools/viewer/sk_app/Window.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M tools/viewer/sk_app/android/Window_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/viewer/sk_app/android/Window_android.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/viewer/sk_app/android/surface_glue_android.h View 5 chunks +3 lines, -10 lines 0 comments Download
M tools/viewer/sk_app/android/surface_glue_android.cpp View 4 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kjlubick
Created Revert of Add drawer with state information
4 years, 6 months ago (2016-05-27 13:21:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016343002/1
4 years, 6 months ago (2016-05-27 13:21:55 UTC) #2
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 13:22:05 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9ad094933817800a2f700d261909000aca762fbe

Powered by Google App Engine
This is Rietveld 408576698