content/browser/accessibility/browser_accessibility.cc - Issue 2016243002: Mac a11y: Add RoleDescription and Value attributes to accessibility information.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 2016243002: Mac a11y: Add RoleDescription and Value attributes to accessibility information. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/accessibility/browser_accessibility.cc

diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc

index bead70f80cbb592797d21544549e7090ecdc925f..0335a93d90429a5995a35d4cb21c6b56300f66ce 100644

--- a/content/browser/accessibility/browser_accessibility.cc

+++ b/content/browser/accessibility/browser_accessibility.cc

@@ -15,6 +15,7 @@

#include "content/browser/accessibility/browser_accessibility_manager.h"

#include "content/common/accessibility_messages.h"

#include "ui/accessibility/ax_text_utils.h"

+#include "ui/accessibility/ax_view_state.h"

#include "ui/accessibility/platform/ax_platform_node.h"

#include "ui/gfx/geometry/rect_f.h"

@@ -952,7 +953,7 @@ base::string16 BrowserAccessibility::GetText() const {

}

bool BrowserAccessibility::HasState(ui::AXState state_enum) const {

- return (GetState() >> state_enum) & 1;

+ return ui::AXViewState::HasStateFlag(GetState(), state_enum);

}

bool BrowserAccessibility::IsCellOrTableHeaderRole() const {

« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility_cocoa.mm » ('j') | ui/accessibility/ax_view_state.h » ('J')