Mac a11y: Add RoleDescription and Value attributes to accessibility information.

ui/accessibility/ax_view_state.h

Index: ui/accessibility/ax_view_state.h
diff --git a/ui/accessibility/ax_view_state.h b/ui/accessibility/ax_view_state.h
index 6126edbac97559b0adf99c5d8f7853a626bea152..a51dad97f46deb4b14de12479ad9e44cf93c37ea 100644
--- a/ui/accessibility/ax_view_state.h
+++ b/ui/accessibility/ax_view_state.h
@@ -24,12 +24,15 @@ namespace ui {
 ////////////////////////////////////////////////////////////////////////////////
 struct AX_EXPORT AXViewState {
  public:
+  static uint32_t AddStateFlag(uint32_t state, ui::AXState state_flag);

[tapted, 2016/06/10 03:17:17]

do we need AddStateFlag? I think it's fine to leave this just as a member
function

[Patti Lor, 2016/06/16 07:05:21]

Done.

+  static bool HasStateFlag(uint32_t state, ui::AXState state_flag);

[tapted, 2016/06/10 03:17:17]

We shouldn't have some overloads static and some non-static. Perhaps
`IsStateFlagSet` or just IsFlagSet since `State` will already be in the scope
qualifier. I think it makes sense for an instance to "have" something, but not
as much for a class interface. also nit: static methods after
constructor/destructor (reorder in .cc too)

[Patti Lor, 2016/06/16 07:05:21]

Done.

+
   AXViewState();
   ~AXViewState();
 
   // Set or check bits in |state_|.
-  void AddStateFlag(ui::AXState state);
-  bool HasStateFlag(ui::AXState state) const;
+  void AddStateFlag(ui::AXState state_flag);
+  bool HasStateFlag(ui::AXState state_flag) const;
 
   // The view's state, a bitmask containing fields such as checked
   // (for a checkbox) and protected (for a password text box). This "state"