Issue 201623003: Rollback transactions by observing them weakly from DatabaseSync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201623003: Rollback transactions by observing them weakly from DatabaseSync. (Closed)

Created:
6 years, 9 months ago by zerny-chromium

Modified:
6 years, 9 months ago

Reviewers:

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rollback transactions by observing them weakly from DatabaseSync. Alternative fix for CL: https://codereview.chromium.org/198793003/ BUG=

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -16 lines)			Patch
M	Source/modules/webdatabase/DatabaseSync.h	View	1 chunk	+19 lines, -1 line	1 comment	Download
M	Source/modules/webdatabase/DatabaseSync.cpp	View	4 chunks	+21 lines, -7 lines	0 comments	Download
M	Source/modules/webdatabase/SQLTransactionBackendSync.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/modules/webdatabase/SQLTransactionBackendSync.cpp	View	2 chunks	+21 lines, -3 lines	0 comments	Download
M	Source/modules/webdatabase/SQLTransactionSync.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/webdatabase/SQLTransactionSync.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/webdatabase/SQLTransactionSync.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

zerny-chromium

6 years, 9 months ago (2014-03-17 09:27:00 UTC) #1

https://codereview.chromium.org/201623003/diff/1/Source/modules/webdatabase/D...
File Source/modules/webdatabase/DatabaseSync.h (right):

https://codereview.chromium.org/201623003/diff/1/Source/modules/webdatabase/D...
Source/modules/webdatabase/DatabaseSync.h:94: ~TransactionObserver();
private:

Expand Messages | Collapse Messages