Source/modules/webdatabase/SQLTransactionSync.cpp - Issue 201623003: Rollback transactions by observing them weakly from DatabaseSync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/SQLTransactionSync.cpp

Issue 201623003: Rollback transactions by observing them weakly from DatabaseSync. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/webdatabase/DatabaseSync.h ('K') | « Source/modules/webdatabase/SQLTransactionSync.h ('k') | Source/modules/webdatabase/SQLTransactionSync.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webdatabase/SQLTransactionSync.cpp

diff --git a/Source/modules/webdatabase/SQLTransactionSync.cpp b/Source/modules/webdatabase/SQLTransactionSync.cpp

index 677d6c5d3f2495a01591e22d2baf254cae5776c9..72a68b6ac35ab3c0d3dbd0e2db21e5e39046f8c1 100644

--- a/Source/modules/webdatabase/SQLTransactionSync.cpp

+++ b/Source/modules/webdatabase/SQLTransactionSync.cpp

@@ -38,9 +38,9 @@

namespace WebCore {

-PassRefPtr<SQLTransactionSync> SQLTransactionSync::create(DatabaseSync* db, PassOwnPtr<SQLTransactionSyncCallback> callback, bool readOnly)

+PassRefPtrWillBeRawPtr<SQLTransactionSync> SQLTransactionSync::create(DatabaseSync* db, PassOwnPtr<SQLTransactionSyncCallback> callback, bool readOnly)

{

- return adoptRef(new SQLTransactionSync(db, callback, readOnly));

+ return adoptRefWillBeNoop(new SQLTransactionSync(db, callback, readOnly));

}

SQLTransactionSync::SQLTransactionSync(DatabaseSync* db, PassOwnPtr<SQLTransactionSyncCallback> callback, bool readOnly)