Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2016223002: Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (Closed)

Created:
4 years, 6 months ago by kotenkov
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (patchset #3 id:40001 of https://codereview.chromium.org/1992873004/ ) Reason for revert: 12.5%-56.9% regression in blink_perf.layout at 395611:395672 Original issue's description: > Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. > > This is a reland of https://codereview.chromium.org/1840163002. > > Performance regressions were addressed in > https://codereview.chromium.org/1937613002 > and https://codereview.chromium.org/1840163002. > > BUG=596760, 599867 > > Committed: https://crrev.com/4d0d91ff393599cb9e605b10b09eb59983145cd4 > Cr-Commit-Position: refs/heads/master@{#395624} TBR=haraken@chromium.org,yutak@chromium.org,tkent@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=596760, 599867, 614852 Committed: https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a Cr-Commit-Position: refs/heads/master@{#396441}

Patch Set 1 #

Patch Set 2 : Resolve conflict in StringImpl.cpp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -86 lines) Patch
M third_party/WebKit/Source/wtf/Deque.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashTable.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 1 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/wtf/WTF.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp View 1 7 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/allocator/PartitionAlloc.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/allocator/PartitionAllocator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/allocator/Partitions.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/dtoa/utils.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/AtomicString.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/CString.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringConcatenate.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringConcatenate.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 1 13 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/TypedArrayBase.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
kotenkov
Created Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.
4 years, 6 months ago (2016-05-27 06:13:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016223002/1
4 years, 6 months ago (2016-05-27 06:14:17 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-05-27 06:14:19 UTC) #4
Yuta Kitamura
LGTM to revert
4 years, 6 months ago (2016-05-27 06:22:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016223002/1
4 years, 6 months ago (2016-05-27 06:23:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/12457) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-05-27 06:25:34 UTC) #9
kotenkov
On 2016/05/27 06:25:34, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-05-27 06:29:40 UTC) #10
kotenkov
Fixed conflict.
4 years, 6 months ago (2016-05-27 06:43:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016223002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016223002/300001
4 years, 6 months ago (2016-05-27 07:03:01 UTC) #14
haraken
LGTM to revert.
4 years, 6 months ago (2016-05-27 07:29:59 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:300001)
4 years, 6 months ago (2016-05-27 11:47:00 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 11:48:25 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90ab609c3dcf497cb08af396f552ca1c8c56e10a
Cr-Commit-Position: refs/heads/master@{#396441}

Powered by Google App Engine
This is Rietveld 408576698