third_party/WebKit/Source/wtf/text/StringConcatenate.h - Issue 2016223002: Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringConcatenate.h

Issue 2016223002: Revert of Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve conflict in StringImpl.cpp. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/wtf/text/StringConcatenate.h

diff --git a/third_party/WebKit/Source/wtf/text/StringConcatenate.h b/third_party/WebKit/Source/wtf/text/StringConcatenate.h

index 10d970a52cb39d154021bc5b82f224920097b114..63a7c4e296292295007d7a15bff37fa10dac4e9e 100644

--- a/third_party/WebKit/Source/wtf/text/StringConcatenate.h

+++ b/third_party/WebKit/Source/wtf/text/StringConcatenate.h

@@ -171,13 +171,9 @@ public:

bool is8Bit() { return false; }

-#if defined(OFFICIAL_BUILD) && defined(NDEBUG)

NO_RETURN_DUE_TO_CRASH void writeTo(LChar*)

-#else

- void writeTo(LChar*)

-#endif

{

- CHECK(false);

+ RELEASE_ASSERT(false);

}

void writeTo(UChar* destination);

« no previous file with comments | « third_party/WebKit/Source/wtf/text/CString.cpp ('k') | third_party/WebKit/Source/wtf/text/StringConcatenate.cpp » ('j') | no next file with comments »