Convert execCommand/unlink.html to use w3c test harness

Convert execCommand/unlink.html to use w3c test harness

This patch converts "execCommand/unlink.html" to use w3c test
harness with |assert_selection()| to simplify for code and improve code health.

This patch also updates |assert_selection()| to serialize selection correctly
when anchor node and focus node aren't |Text| node, and adds sanity check
for expected text.

This patch is a preparation of committing crrev.com/2001083002, Make
FrameSelection to track associated Document.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/786659dee62e423b2a5f7f88ce8a087e8de18986
Cr-Commit-Position: refs/heads/master@{#396791}

[yosin_UTC9, 2016-05-27 04:10:34]

Description was changed from

==========
na# Enter a description of the change.
2016-05-27T10:53:59

BUG=
==========

to

==========
Convert execCommand/unlink.html to use w3c test harness

This patch converts "execCommand/unlink.html" to use w3c test
harness with |assert_selection()| to simplify for code and improve code health.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-05-27 04:10:34]

yosin@chromium.org changed reviewers:
+ yoichio@chromium.org

[yosin_UTC9, 2016-05-27 04:10:44]

PTAL

[yosin_UTC9, 2016-05-27 05:27:51]

Description was changed from

==========
Convert execCommand/unlink.html to use w3c test harness

This patch converts "execCommand/unlink.html" to use w3c test
harness with |assert_selection()| to simplify for code and improve code health.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Convert execCommand/unlink.html to use w3c test harness

This patch converts "execCommand/unlink.html" to use w3c test
harness with |assert_selection()| to simplify for code and improve code health.

This patch is a preparation of committing crrev.com/2001083002, Make
FrameSelection to track associated Document.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yoichio, 2016-05-27 09:14:39]

https://codereview.chromium.org/2016173002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/editing/execCommand/unlink.html (right):

https://codereview.chromium.org/2016173002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/unlink.html:29: '^<div
contenteditable><img src="../resources/abe.png"></div>',
It is not '<div contenteditable>^<img src="../resources/abe.png">|</div>' ?
Please check selection state in assert_selection.

[yosin_UTC9, 2016-05-27 09:53:11]

Description was changed from

==========
Convert execCommand/unlink.html to use w3c test harness

This patch converts "execCommand/unlink.html" to use w3c test
harness with |assert_selection()| to simplify for code and improve code health.

This patch is a preparation of committing crrev.com/2001083002, Make
FrameSelection to track associated Document.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Convert execCommand/unlink.html to use w3c test harness

This patch converts "execCommand/unlink.html" to use w3c test
harness with |assert_selection()| to simplify for code and improve code health.

This patch also updates |assert_selection()| to serialize selection correctly
when anchor node and focus node aren't |Text| node, and adds sanity check
for expected text.

This patch is a preparation of committing crrev.com/2001083002, Make
FrameSelection to track associated Document.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-05-27 09:54:17]

PTAL

https://codereview.chromium.org/2016173002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/editing/execCommand/unlink.html (right):

https://codereview.chromium.org/2016173002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/unlink.html:29: '^<div
contenteditable><img src="../resources/abe.png"></div>',
On 2016/05/27 at 09:14:39, yoichio wrote:
> It is not '<div contenteditable>^<img src="../resources/abe.png">|</div>' ?
> Please check selection state in assert_selection.

Good catch! fixed along with fixing of assert_selection().

[yosin_UTC9, 2016-05-30 01:32:42]

On 2016/05/27 at 09:54:17, Yosi_UTC9 wrote:
> PTAL
> 
>
https://codereview.chromium.org/2016173002/diff/1/third_party/WebKit/LayoutTe...
> File third_party/WebKit/LayoutTests/editing/execCommand/unlink.html (right):
> 
>
https://codereview.chromium.org/2016173002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/editing/execCommand/unlink.html:29: '^<div
contenteditable><img src="../resources/abe.png"></div>',
> On 2016/05/27 at 09:14:39, yoichio wrote:
> > It is not '<div contenteditable>^<img src="../resources/abe.png">|</div>' ?
> > Please check selection state in assert_selection.
> 
> Good catch! fixed along with fixing of assert_selection().

I recall this patch set #2.
I'll move assert_selection() change to another CL with test.

[yoichio, 2016-05-30 02:08:37]

https://codereview.chromium.org/2016173002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/assert_selection.js (left):

https://codereview.chromium.org/2016173002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/assert_selection.js:422: if
(element.parenNode === this.selection_.focusNode &&
The strict mode can't check this? Sad,,,

https://codereview.chromium.org/2016173002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/assert_selection.js (right):

https://codereview.chromium.org/2016173002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/assert_selection.js:349: class Serializer
{
Add comment describing simple example of 
sample = new Serializer(selection);
sample.serialize(element).

https://codereview.chromium.org/2016173002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/assert_selection.js:488: class Sample {
Add comment describing simple example of 
sample = new Sample(text);
sample.serialize().

https://codereview.chromium.org/2016173002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/assert_selection.js:581: function
checkExpectedText(expectedText) {
Could you extract sanity check functions from this and |Sample.load|
 like "shouldHaveAtMostOneAnchor(text)" ?

[yosin_UTC9, 2016-05-30 10:06:28]

PTAL

Verified with May 30's version of assert_selection()

[yoichio, 2016-05-31 01:54:01]

Please git cl try

[yosin_UTC9, 2016-05-31 01:55:09]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 01:55:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2016173002/40001

[commit-bot: I haz the power, 2016-05-31 02:58:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 02:58:40]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-05-31 03:54:23]

PTAL
Try bots succeeded.

[yoichio, 2016-05-31 05:53:30]

lgtm

[yosin_UTC9, 2016-05-31 06:03:20]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-05-31 06:03:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2016173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2016173002/40001

[commit-bot: I haz the power, 2016-05-31 06:07:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-31 06:09:40]

Description was changed from

==========
Convert execCommand/unlink.html to use w3c test harness

This patch converts "execCommand/unlink.html" to use w3c test
harness with |assert_selection()| to simplify for code and improve code health.

This patch also updates |assert_selection()| to serialize selection correctly
when anchor node and focus node aren't |Text| node, and adds sanity check
for expected text.

This patch is a preparation of committing crrev.com/2001083002, Make
FrameSelection to track associated Document.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Convert execCommand/unlink.html to use w3c test harness

This patch converts "execCommand/unlink.html" to use w3c test
harness with |assert_selection()| to simplify for code and improve code health.

This patch also updates |assert_selection()| to serialize selection correctly
when anchor node and focus node aren't |Text| node, and adds sanity check
for expected text.

This patch is a preparation of committing crrev.com/2001083002, Make
FrameSelection to track associated Document.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/786659dee62e423b2a5f7f88ce8a087e8de18986
Cr-Commit-Position: refs/heads/master@{#396791}
==========

[commit-bot: I haz the power, 2016-05-31 06:09:41]

Patchset 3 (id:??) landed as
https://crrev.com/786659dee62e423b2a5f7f88ce8a087e8de18986
Cr-Commit-Position: refs/heads/master@{#396791}