Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Issue 2015983002: Revert of base: Add debugging to track down CreateFileMapping() errors. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of base: Add debugging to track down CreateFileMapping() errors. (patchset #1 id:1 of https://codereview.chromium.org/2005853003/ ) Reason for revert: No longer necessary: https://bugs.chromium.org/p/chromium/issues/detail?id=585013 Original issue's description: > base: Add debugging to track down CreateFileMapping() errors. > > BUG=585013 > > Committed: https://crrev.com/9e1f3088559e8c51a6e109851df7a77f1acc76db > Cr-Commit-Position: refs/heads/master@{#395639} TBR=thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585013 Committed: https://crrev.com/7355f354f1cbd274478929f2c476ba41046f97e4 Cr-Commit-Position: refs/heads/master@{#396258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M base/memory/shared_memory_win.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
erikchen
Created Revert of base: Add debugging to track down CreateFileMapping() errors.
4 years, 6 months ago (2016-05-26 18:31:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015983002/1
4 years, 6 months ago (2016-05-26 18:32:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015983002/1
4 years, 6 months ago (2016-05-26 19:01:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015983002/1
4 years, 6 months ago (2016-05-26 19:31:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-26 19:42:37 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 19:44:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7355f354f1cbd274478929f2c476ba41046f97e4
Cr-Commit-Position: refs/heads/master@{#396258}

Powered by Google App Engine
This is Rietveld 408576698