Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: base/memory/shared_memory_win.cc

Issue 2015983002: Revert of base: Add debugging to track down CreateFileMapping() errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/shared_memory_win.cc
diff --git a/base/memory/shared_memory_win.cc b/base/memory/shared_memory_win.cc
index 6623e8caefde4b74157be1723414706418374f0f..7de87a98a9dd91a3647c4c20c47e8c977136e9c9 100644
--- a/base/memory/shared_memory_win.cc
+++ b/base/memory/shared_memory_win.cc
@@ -8,8 +8,6 @@
#include <stddef.h>
#include <stdint.h>
-#include "base/debug/alias.h"
-#include "base/debug/dump_without_crashing.h"
#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
#include "base/rand_util.h"
@@ -110,11 +108,6 @@
HANDLE h = CreateFileMapping(INVALID_HANDLE_VALUE, sa, PAGE_READWRITE, 0,
static_cast<DWORD>(rounded_size), name);
if (!h) {
- // Debugging to help track down https://crbug.com/585013
- DWORD last_error = ::GetLastError();
- base::debug::Alias(&last_error);
- base::debug::DumpWithoutCrashing();
-
LogError(CREATE_FILE_MAPPING_FAILURE);
return nullptr;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698