Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2015933002: [iOS/GN] Fix the extension used by application extension bundles. (Closed)

Created:
4 years, 7 months ago by sdefresne
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, Olivier
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/GN] Fix the extension used by application extension bundles. Application extension bundle uses the ".appex" extension, not ".appext". Fix the extension used by the template and the template name. BUG=603032, 603036 Committed: https://crrev.com/f9aecef3dcf22d4cdd4cd84bc3cc0bb39abb58f6 Cr-Commit-Position: refs/heads/master@{#396217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/ios/rules.gni View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look (Olivier pointed out that I used the wrong extension) and send ...
4 years, 7 months ago (2016-05-26 15:53:54 UTC) #2
Robert Sesek
lgtm
4 years, 7 months ago (2016-05-26 15:54:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015933002/1
4 years, 7 months ago (2016-05-26 15:55:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 17:34:50 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 17:36:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9aecef3dcf22d4cdd4cd84bc3cc0bb39abb58f6
Cr-Commit-Position: refs/heads/master@{#396217}

Powered by Google App Engine
This is Rietveld 408576698