Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2008853002:
[GN] Define SK_BUILD_NO_OPTS when building skia on iOS. (Closed)
Description[GN] Define SK_BUILD_NO_OPTS when building skia on iOS.
When targetting iOS and using gyp to generate the build files, it is not
possible to select files to build depending on the architecture. Due to
that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS
was defined.
Since it is possible to select the correct optimised version when using
gn, this pessimisation is hurting the build. Introduce a new define to
disable the optimisation SK_BUILD_NO_OPTS and define it when building for
iOS using gyp and gn until the transitition is over.
Once gn is the only supported build system, then we'll just remove this
define and get optimisation for skia on iOS.
BUG=607933
Committed: https://crrev.com/1c5bc239dd8c0e95319b98a6195cf35c7b00b1b1
Cr-Commit-Position: refs/heads/master@{#396261}
Patch Set 1 #Patch Set 2 : Disable optimisation with gn too #Patch Set 3 : Fix compilation on iOS device #
Depends on Patchset: Messages
Total messages: 21 (12 generated)
Description was changed from ========== [GN] Define SK_BUILD_NO_OPTS when building skia with gyp. When targetting iOS and using gyp to generate the build files, it is not possible to select files to build depending on the architecture. Due to that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS was defined. Since it is possible to select the correct optimised version when using gn, this pessimisation is hurting the build. Introduce a new define to disable the optimisation SK_BUILD_NO_OPTS and define it when building for iOS using gyp but not when using gn. BUG=607933 ========== to ========== [GN] Define SK_BUILD_NO_OPTS when building skia with gyp. When targetting iOS and using gyp to generate the build files, it is not possible to select files to build depending on the architecture. Due to that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS was defined. Since it is possible to select the correct optimised version when using gn, this pessimisation is hurting the build. Introduce a new define to disable the optimisation SK_BUILD_NO_OPTS and define it when building for iOS using gyp but not when using gn. BUG=607933 ==========
sdefresne@chromium.org changed reviewers: + bsalomon@google.com
Please take a look. This flag is currently unused by skia (it is added by https://codereview.chromium.org/2002423002/) but this needs to land in Chromium before the introduction of the macro in skia properly.
Description was changed from ========== [GN] Define SK_BUILD_NO_OPTS when building skia with gyp. When targetting iOS and using gyp to generate the build files, it is not possible to select files to build depending on the architecture. Due to that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS was defined. Since it is possible to select the correct optimised version when using gn, this pessimisation is hurting the build. Introduce a new define to disable the optimisation SK_BUILD_NO_OPTS and define it when building for iOS using gyp but not when using gn. BUG=607933 ========== to ========== [GN] Define SK_BUILD_NO_OPTS when building skia with gyp. When targetting iOS and using gyp to generate the build files, it is not possible to select files to build depending on the architecture. Due to that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS was defined. Since it is possible to select the correct optimised version when using gn, this pessimisation is hurting the build. Introduce a new define to disable the optimisation SK_BUILD_NO_OPTS and define it when building for iOS using gyp and gn until the transitition is over. Once gn is the only supported build system, then we'll just remove this define and get optimisation for skia on iOS. BUG=607933 ==========
Description was changed from ========== [GN] Define SK_BUILD_NO_OPTS when building skia with gyp. When targetting iOS and using gyp to generate the build files, it is not possible to select files to build depending on the architecture. Due to that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS was defined. Since it is possible to select the correct optimised version when using gn, this pessimisation is hurting the build. Introduce a new define to disable the optimisation SK_BUILD_NO_OPTS and define it when building for iOS using gyp and gn until the transitition is over. Once gn is the only supported build system, then we'll just remove this define and get optimisation for skia on iOS. BUG=607933 ========== to ========== [GN] Define SK_BUILD_NO_OPTS when building skia on iOS. When targetting iOS and using gyp to generate the build files, it is not possible to select files to build depending on the architecture. Due to that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS was defined. Since it is possible to select the correct optimised version when using gn, this pessimisation is hurting the build. Introduce a new define to disable the optimisation SK_BUILD_NO_OPTS and define it when building for iOS using gyp and gn until the transitition is over. Once gn is the only supported build system, then we'll just remove this define and get optimisation for skia on iOS. BUG=607933 ==========
sdefresne@chromium.org changed reviewers: + mtklein@google.com
Updated to also disable optimisation with GN as discussed in https://codereview.chromium.org/2002423002/. Please take a look.
mtklein@chromium.org changed reviewers: + mtklein@chromium.org
lgtm
On 2016/05/24 15:57:24, mtklein_C wrote: > lgtm Thank you.
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008853002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@chromium.org Link to the patchset: https://codereview.chromium.org/2008853002/#ps40001 (title: "Fix compilation on iOS device")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008853002/40001
Message was sent while issue was closed.
Description was changed from ========== [GN] Define SK_BUILD_NO_OPTS when building skia on iOS. When targetting iOS and using gyp to generate the build files, it is not possible to select files to build depending on the architecture. Due to that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS was defined. Since it is possible to select the correct optimised version when using gn, this pessimisation is hurting the build. Introduce a new define to disable the optimisation SK_BUILD_NO_OPTS and define it when building for iOS using gyp and gn until the transitition is over. Once gn is the only supported build system, then we'll just remove this define and get optimisation for skia on iOS. BUG=607933 ========== to ========== [GN] Define SK_BUILD_NO_OPTS when building skia on iOS. When targetting iOS and using gyp to generate the build files, it is not possible to select files to build depending on the architecture. Due to that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS was defined. Since it is possible to select the correct optimised version when using gn, this pessimisation is hurting the build. Introduce a new define to disable the optimisation SK_BUILD_NO_OPTS and define it when building for iOS using gyp and gn until the transitition is over. Once gn is the only supported build system, then we'll just remove this define and get optimisation for skia on iOS. BUG=607933 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [GN] Define SK_BUILD_NO_OPTS when building skia on iOS. When targetting iOS and using gyp to generate the build files, it is not possible to select files to build depending on the architecture. Due to that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS was defined. Since it is possible to select the correct optimised version when using gn, this pessimisation is hurting the build. Introduce a new define to disable the optimisation SK_BUILD_NO_OPTS and define it when building for iOS using gyp and gn until the transitition is over. Once gn is the only supported build system, then we'll just remove this define and get optimisation for skia on iOS. BUG=607933 ========== to ========== [GN] Define SK_BUILD_NO_OPTS when building skia on iOS. When targetting iOS and using gyp to generate the build files, it is not possible to select files to build depending on the architecture. Due to that, the skia code was disabling all optimisation when SK_BUILD_FOR_IOS was defined. Since it is possible to select the correct optimised version when using gn, this pessimisation is hurting the build. Introduce a new define to disable the optimisation SK_BUILD_NO_OPTS and define it when building for iOS using gyp and gn until the transitition is over. Once gn is the only supported build system, then we'll just remove this define and get optimisation for skia on iOS. BUG=607933 Committed: https://crrev.com/1c5bc239dd8c0e95319b98a6195cf35c7b00b1b1 Cr-Commit-Position: refs/heads/master@{#396261} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1c5bc239dd8c0e95319b98a6195cf35c7b00b1b1 Cr-Commit-Position: refs/heads/master@{#396261} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
