Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2015783002: Invalidate touchEventTargetRects in ScrollingCoordinator when toggling touch emulation. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, kenneth.christiansen, caseq+blink_chromium.org, lushnikov+blink_chromium.org, blink-layers+watch_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invalidate touchEventTargetRects in ScrollingCoordinator when toggling touch emulation. We have to move RuntimeEnableCheck further to apply empty rects after disabling touch emulation. BUG=613219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -4 lines) Patch
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/touch-event-target-rects.html View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015783002/1
4 years, 7 months ago (2016-05-26 03:07:43 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 03:55:30 UTC) #4 
Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698