third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 2015783002: Invalidate touchEventTargetRects in ScrollingCoordinator when toggling touch emulation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2015783002: Invalidate touchEventTargetRects in ScrollingCoordinator when toggling touch emulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h ('k') | third_party/WebKit/Source/web/DevToolsEmulator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

index 24e4dc1b671fffe8f58b00f686509bf9be4d7d7c..9bafe0a16940bdda149c78b5c1942491385a2556 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -550,9 +550,6 @@ void ScrollingCoordinator::updateTouchEventTargetRectsIfNeeded()

{

TRACE_EVENT0("input", "ScrollingCoordinator::updateTouchEventTargetRectsIfNeeded");

- if (!RuntimeEnabledFeatures::touchEnabled())

- return;

LayerHitTestRects touchEventTargetRects;

computeTouchEventTargetRects(touchEventTargetRects);

setTouchEventTargetRects(touchEventTargetRects);

@@ -860,7 +857,8 @@ static void accumulateDocumentTouchEventTargetRects(LayerHitTestRects& rects, co

void ScrollingCoordinator::computeTouchEventTargetRects(LayerHitTestRects& rects)

{

TRACE_EVENT0("input", "ScrollingCoordinator::computeTouchEventTargetRects");

- ASSERT(RuntimeEnabledFeatures::touchEnabled());

+ if (!RuntimeEnabledFeatures::touchEnabled())

+ return;

Document* document = m_page->deprecatedLocalMainFrame()->document();

if (!document || !document->view())