Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 201573013: Rename MediaHasVideo bit to MediaCanToggleControls. (Closed)

Created:
6 years, 9 months ago by sandersd (OOO until July 31)
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rename MediaHasVideo bit to MediaCanToggleControls. Blink side change is https://codereview.chromium.org/200723010/. BUG=179489 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sandersd (OOO until July 31)
Should be an easy one, but I do need to wait for a DEPS roll ...
6 years, 8 months ago (2014-04-02 21:02:19 UTC) #1
Avi (use Gerrit)
lgtm That works.
6 years, 8 months ago (2014-04-02 21:32:33 UTC) #2
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 8 months ago (2014-04-03 17:41:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/201573013/1
6 years, 8 months ago (2014-04-03 17:41:48 UTC) #4
eseidel
lgtm
6 years, 8 months ago (2014-04-03 19:49:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 21:06:41 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 21:06:41 UTC) #7
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 8 months ago (2014-04-03 21:17:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/201573013/1
6 years, 8 months ago (2014-04-03 21:17:57 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 21:20:11 UTC) #10
Message was sent while issue was closed.
Change committed as 261528

Powered by Google App Engine
This is Rietveld 408576698