Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 201573013: Rename MediaHasVideo bit to MediaCanToggleControls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index a90d70486bc3d56a8129172242af7c07cef62865..c2917ccbe9f69839b7d7472934614676cbd9c59d 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -1253,12 +1253,9 @@ bool RenderViewContextMenu::IsCommandIdEnabled(int id) const {
(params_.media_flags &
WebContextMenuData::MediaInError) == 0;
- // Media controls can be toggled only for video player. If we toggle
- // controls for audio then the player disappears, and there is no way to
- // return it back.
case IDC_CONTENT_CONTEXT_CONTROLS:
return (params_.media_flags &
- WebContextMenuData::MediaHasVideo) != 0;
+ WebContextMenuData::MediaCanToggleControls) != 0;
case IDC_CONTENT_CONTEXT_ROTATECW:
case IDC_CONTENT_CONTEXT_ROTATECCW:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698