Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Unified Diff: appengine/findit/templates/waterfall/compile_failure.html

Issue 2015703003: [Findit] UI: Only display try job result to non-admin users if it's available. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/templates/build_failure.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/templates/waterfall/compile_failure.html
diff --git a/appengine/findit/templates/waterfall/compile_failure.html b/appengine/findit/templates/waterfall/compile_failure.html
index ba06445b56a837061dadf5f5afc53096beaecf60..194069739d1a656024b179b80ee70ef727dcc4fe 100644
--- a/appengine/findit/templates/waterfall/compile_failure.html
+++ b/appengine/findit/templates/waterfall/compile_failure.html
@@ -204,6 +204,7 @@
</div>
<br>
+ {% set show_heuristic = True %}
{% if try_job %}
<div>
<b>Try-job Result:</b><br>
@@ -216,6 +217,7 @@
{% if try_job.failed %}
<span class="error">Try job ran into error!</span>
{% elif try_job.culprit %}
+ {% set show_heuristic = False %}
stgao 2016/05/26 01:02:22 Not bail out for admin.
chanli 2016/05/26 20:15:13 Done.
Culprit: {{try_job.culprit.repo_name or 'chromium'}} <a href="{{try_job.culprit.url or try_job.culprit.review_url or ('https://chromium.googlesource.com/chromium/src.git/+/' + try_job.culprit.revision)}}">{{try_job.culprit.commit_position or try_job.culprit.revision}}</a>
{% else %}
<div>No culprit found!</div>
@@ -225,6 +227,7 @@
<br>
{% endif%}
+ {% if show_heuristic %}
<b>Heuristic analysis result:</b>
<div id="heuristic-analysis">
Status: <span id="status_message"></span>
@@ -278,6 +281,7 @@
{% endif %}
{% endif %}
</div>
+ {% endif %}
{% if analysis_completed %}
<br>
« no previous file with comments | « appengine/findit/templates/build_failure.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698