Chromium Code Reviews Chromium Code Reviews
Issue 2015703003:
[Findit] UI: Only display try job result to non-admin users if it's available. (Closed)
Base URL: https://chromium.googlesource.com/infra/infra.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <head> | 2 <head> |
| 3 <title>Compile Failure</title> | 3 <title>Compile Failure</title> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <link rel="stylesheet" href="/common.css"> | 5 <link rel="stylesheet" href="/common.css"> |
| 6 <style> | 6 <style> |
| 7 .pending { | 7 .pending { |
| 8 color: #666666; | 8 color: #666666; |
| 9 background-color: #fffc6c; | 9 background-color: #fffc6c; |
| 10 border-color: #c5c56d; | 10 border-color: #c5c56d; |
| (...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 197 {% endif %} | 197 {% endif %} |
| 198 {%if show_debug_info %} | 198 {%if show_debug_info %} |
| 199 <a href="/waterfall/failure-log?url=https://build.chromium.org/p/{{master_ name}}/builders/{{builder_name}}/builds/{{build_number}}/steps/compile">compile stdio</a> | 199 <a href="/waterfall/failure-log?url=https://build.chromium.org/p/{{master_ name}}/builders/{{builder_name}}/builds/{{build_number}}/steps/compile">compile stdio</a> |
| 200 {% else %} | 200 {% else %} |
| 201 <a href="https://build.chromium.org/p/{{master_name}}/builders/{{builder_n ame}}/builds/{{build_number}}/steps/compile">compile stdio</a> | 201 <a href="https://build.chromium.org/p/{{master_name}}/builders/{{builder_n ame}}/builds/{{build_number}}/steps/compile">compile stdio</a> |
| 202 {% endif %} | 202 {% endif %} |
| 203 <br> | 203 <br> |
| 204 </div> | 204 </div> |
| 205 <br> | 205 <br> |
| 206 | 206 |
| 207 {% set show_heuristic = True %} | |
| 207 {% if try_job %} | 208 {% if try_job %} |
| 208 <div> | 209 <div> |
| 209 <b>Try-job Result:</b><br> | 210 <b>Try-job Result:</b><br> |
| 210 Status: <span class="{{try_job.status}}">{{try_job.status}}</span> | 211 Status: <span class="{{try_job.status}}">{{try_job.status}}</span> |
| 211 {% if try_job.url %} | 212 {% if try_job.url %} |
| 212 <a href="{{try_job.url}}">try-job</a> | 213 <a href="{{try_job.url}}">try-job</a> |
| 213 {% endif %} | 214 {% endif %} |
| 214 <br> | 215 <br> |
| 215 {% if try_job.completed %} | 216 {% if try_job.completed %} |
| 216 {% if try_job.failed %} | 217 {% if try_job.failed %} |
| 217 <span class="error">Try job ran into error!</span> | 218 <span class="error">Try job ran into error!</span> |
| 218 {% elif try_job.culprit %} | 219 {% elif try_job.culprit %} |
| 220 {% set show_heuristic = False %} | |
|
stgao
2016/05/26 01:02:22
Not bail out for admin.
chanli
2016/05/26 20:15:13
Done.
| |
| 219 Culprit: {{try_job.culprit.repo_name or 'chromium'}} <a href="{{try_job. culprit.url or try_job.culprit.review_url or ('https://chromium.googlesource.com /chromium/src.git/+/' + try_job.culprit.revision)}}">{{try_job.culprit.commit_po sition or try_job.culprit.revision}}</a> | 221 Culprit: {{try_job.culprit.repo_name or 'chromium'}} <a href="{{try_job. culprit.url or try_job.culprit.review_url or ('https://chromium.googlesource.com /chromium/src.git/+/' + try_job.culprit.revision)}}">{{try_job.culprit.commit_po sition or try_job.culprit.revision}}</a> |
| 220 {% else %} | 222 {% else %} |
| 221 <div>No culprit found!</div> | 223 <div>No culprit found!</div> |
| 222 {% endif%} | 224 {% endif%} |
| 223 {% endif%} | 225 {% endif%} |
| 224 </div> | 226 </div> |
| 225 <br> | 227 <br> |
| 226 {% endif%} | 228 {% endif%} |
| 227 | 229 |
| 230 {% if show_heuristic %} | |
| 228 <b>Heuristic analysis result:</b> | 231 <b>Heuristic analysis result:</b> |
| 229 <div id="heuristic-analysis"> | 232 <div id="heuristic-analysis"> |
| 230 Status: <span id="status_message"></span> | 233 Status: <span id="status_message"></span> |
| 231 {% if show_debug_info %} | 234 {% if show_debug_info %} |
| 232 {% if pipeline_status_path %} | 235 {% if pipeline_status_path %} |
| 233 <a href="{{pipeline_status_path}}">pipeline</a> | 236 <a href="{{pipeline_status_path}}">pipeline</a> |
| 234 {% endif %} | 237 {% endif %} |
| 235 <br> | 238 <br> |
| 236 Requested: {{analysis_request_time | default('N/A', true)}}<br> | 239 Requested: {{analysis_request_time | default('N/A', true)}}<br> |
| 237 {% if analysis_duration %} | 240 {% if analysis_duration %} |
| (...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 271 {% endfor %} | 274 {% endfor %} |
| 272 </td> | 275 </td> |
| 273 </tr> | 276 </tr> |
| 274 {% endfor %} | 277 {% endfor %} |
| 275 </tbody> | 278 </tbody> |
| 276 </table> | 279 </table> |
| 277 </div> | 280 </div> |
| 278 {% endif %} | 281 {% endif %} |
| 279 {% endif %} | 282 {% endif %} |
| 280 </div> | 283 </div> |
| 284 {% endif %} | |
| 281 | 285 |
| 282 {% if analysis_completed %} | 286 {% if analysis_completed %} |
| 283 <br> | 287 <br> |
| 284 <div> | 288 <div> |
| 285 <b>Feedback on Findit result:</b><br> | 289 <b>Feedback on Findit result:</b><br> |
| 286 <div class="thumbs-up-down"> | 290 <div class="thumbs-up-down"> |
| 287 <div class="triage thumb-up">Correct <img src="https://www.gstatic.com/ima ges/icons/material/system/1x/thumb_up_black_24dp.png"/></div> | 291 <div class="triage thumb-up">Correct <img src="https://www.gstatic.com/ima ges/icons/material/system/1x/thumb_up_black_24dp.png"/></div> |
| 288 <div class="triage thumb-down"><img src="https://www.gstatic.com/images/ic ons/material/system/1x/thumb_down_black_24dp.png"/> Incorrect</div> | 292 <div class="triage thumb-down"><img src="https://www.gstatic.com/images/ic ons/material/system/1x/thumb_down_black_24dp.png"/> Incorrect</div> |
| 289 </div> | 293 </div> |
| 290 </div> | 294 </div> |
| (...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 331 appearing in the failure log. (eg: file.h was changed and | 335 appearing in the failure log. (eg: file.h was changed and |
| 332 file_unittest.cc or file_impl.cc appeared in the log.)</li> | 336 file_unittest.cc or file_impl.cc appeared in the log.)</li> |
| 333 <li>1: The CL rolled a dependency within src/DEPS and a file of that | 337 <li>1: The CL rolled a dependency within src/DEPS and a file of that |
| 334 dependency appears in the failure log. (eg: third_party/dep | 338 dependency appears in the failure log. (eg: third_party/dep |
| 335 was changed in src/DEPS and third_party/dep/f.cpp appeared | 339 was changed in src/DEPS and third_party/dep/f.cpp appeared |
| 336 in the log.)</li> | 340 in the log.)</li> |
| 337 </ul> | 341 </ul> |
| 338 (More rules will be added when implemented.) | 342 (More rules will be added when implemented.) |
| 339 </div> | 343 </div> |
| 340 </body> | 344 </body> |
| OLD | NEW |
