[Findit] UI: Only display try job result to non-admin users if it's available.

[Findit] UI: Only display try job result to non-admin users  if it's available.

Only display try job result to non-admin users if it's available.
Display heuristic results if try job is not ready or there is no try job result.

Demo:
Compile: https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20(dbg)/builds/106469

Test: https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/builds/12758

https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)/builds/52854


BUG=614562
Committed: https://chromium.googlesource.com/infra/infra/+/f46208fd788b9e2951f6a8d10b8e47bd61002010

[chanli, 2016-05-25 23:45:50]

Description was changed from

==========
[Findit] UI: Only display try job result to non-admin users  if it's available.

Only display try job result to non-admin users if it's available.
Display heuristic results if try job is not ready or there is no try job result.

BUG=614562
==========

to

==========
[Findit] UI: Only display try job result to non-admin users  if it's available.

Only display try job result to non-admin users if it's available.
Display heuristic results if try job is not ready or there is no try job result.

Demo:
Compile:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Test:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...
BUG=614562
==========

[chanli, 2016-05-25 23:46:03]

Description was changed from

==========
[Findit] UI: Only display try job result to non-admin users  if it's available.

Only display try job result to non-admin users if it's available.
Display heuristic results if try job is not ready or there is no try job result.

Demo:
Compile:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Test:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...
BUG=614562
==========

to

==========
[Findit] UI: Only display try job result to non-admin users  if it's available.

Only display try job result to non-admin users if it's available.
Display heuristic results if try job is not ready or there is no try job result.

Demo:
Compile:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Test:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...


BUG=614562
==========

[chanli, 2016-05-25 23:46:19]

chanli@chromium.org changed reviewers:
+ lijeffrey@chromium.org, stgao@chromium.org

[chanli, 2016-05-25 23:46:19]

ptal

[chanli, 2016-05-26 00:28:44]

ptal

[stgao, 2016-05-26 01:02:23]

lgtm with nits.

https://codereview.chromium.org/2015703003/diff/1/appengine/findit/templates/...
File appengine/findit/templates/waterfall/compile_failure.html (right):

https://codereview.chromium.org/2015703003/diff/1/appengine/findit/templates/...
appengine/findit/templates/waterfall/compile_failure.html:220: {% set
show_heuristic = False %}
Not bail out for admin.

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
File appengine/findit/templates/build_failure.html (right):

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
appengine/findit/templates/build_failure.html:273: var build_number =
result.try_job.try_job_key.split('/')[2];  // try_job_key would look like:
'master_name/builder_name/build_number'.
This is not related to this CL.

It seems not good for the logic of format for the try-job key to propagate to
the UI.

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
appengine/findit/templates/build_failure.html:501: <th title="The source of
result: Try Job or Heuristic Analysis.">Result Source</th>
"Result Source" --> "Analysis approach"? It would be great if the tooltip
explains the difference in a few words.

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
appengine/findit/templates/build_failure.html:520: <th rowspan="2" title="Failed
step name" width="150px">Step</th>
Should we show that the result is from heuristic? Or don't even show any
analysis result?

Same for "unclassified" below.

[chanli, 2016-05-26 20:15:13]

https://codereview.chromium.org/2015703003/diff/1/appengine/findit/templates/...
File appengine/findit/templates/waterfall/compile_failure.html (right):

https://codereview.chromium.org/2015703003/diff/1/appengine/findit/templates/...
appengine/findit/templates/waterfall/compile_failure.html:220: {% set
show_heuristic = False %}
On 2016/05/26 01:02:22, stgao wrote:
> Not bail out for admin.

Done.

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
File appengine/findit/templates/build_failure.html (right):

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
appengine/findit/templates/build_failure.html:273: var build_number =
result.try_job.try_job_key.split('/')[2];  // try_job_key would look like:
'master_name/builder_name/build_number'.
On 2016/05/26 01:02:22, stgao wrote:
> This is not related to this CL.
> 
> It seems not good for the logic of format for the try-job key to propagate to
> the UI.

I removed the comments, though I'm not sure exactly what do you mean here.

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
appengine/findit/templates/build_failure.html:501: <th title="The source of
result: Try Job or Heuristic Analysis.">Result Source</th>
On 2016/05/26 01:02:22, stgao wrote:
> "Result Source" --> "Analysis approach"? It would be great if the tooltip
> explains the difference in a few words.

Done.

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
appengine/findit/templates/build_failure.html:520: <th rowspan="2" title="Failed
step name" width="150px">Step</th>
On 2016/05/26 01:02:22, stgao wrote:
> Should we show that the result is from heuristic? Or don't even show any
> analysis result?
> 
> Same for "unclassified" below.

Done.

[stgao, 2016-05-26 20:27:08]

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
File appengine/findit/templates/build_failure.html (right):

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
appengine/findit/templates/build_failure.html:273: var build_number =
result.try_job.try_job_key.split('/')[2];  // try_job_key would look like:
'master_name/builder_name/build_number'.
On 2016/05/26 20:15:13, chanli wrote:
> On 2016/05/26 01:02:22, stgao wrote:
> > This is not related to this CL.
> > 
> > It seems not good for the logic of format for the try-job key to propagate
to
> > the UI.
> 
> I removed the comments, though I'm not sure exactly what do you mean here.

It's better for the try_job_key format to be restricted to the code of the
backend/handler layer. The UI should know nothing about how it is constructed --
e.g. the second part is the build number.

It's better to keep the comment for now though.

[chanli, 2016-05-26 21:22:26]

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
File appengine/findit/templates/build_failure.html (right):

https://codereview.chromium.org/2015703003/diff/20001/appengine/findit/templa...
appengine/findit/templates/build_failure.html:273: var build_number =
result.try_job.try_job_key.split('/')[2];  // try_job_key would look like:
'master_name/builder_name/build_number'.
On 2016/05/26 20:27:08, stgao wrote:
> On 2016/05/26 20:15:13, chanli wrote:
> > On 2016/05/26 01:02:22, stgao wrote:
> > > This is not related to this CL.
> > > 
> > > It seems not good for the logic of format for the try-job key to propagate
> to
> > > the UI.
> > 
> > I removed the comments, though I'm not sure exactly what do you mean here.
> 
> It's better for the try_job_key format to be restricted to the code of the
> backend/handler layer. The UI should know nothing about how it is constructed
--
> e.g. the second part is the build number.
> 
> It's better to keep the comment for now though.

Got it. I'll make the change in a separate CL.

[chanli, 2016-05-26 22:38:37]

The CQ bit was checked by chanli@chromium.org

[chanli, 2016-05-26 22:38:38]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2015703003/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-05-26 22:38:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015703003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015703003/60001

[commit-bot: I haz the power, 2016-05-26 22:44:54]

Description was changed from

==========
[Findit] UI: Only display try job result to non-admin users  if it's available.

Only display try job result to non-admin users if it's available.
Display heuristic results if try job is not ready or there is no try job result.

Demo:
Compile:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Test:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...


BUG=614562
==========

to

==========
[Findit] UI: Only display try job result to non-admin users  if it's available.

Only display try job result to non-admin users if it's available.
Display heuristic results if try job is not ready or there is no try job result.

Demo:
Compile:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

Test:
https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...

https://chanli-dot-findit-for-me.appspot.com/waterfall/build-failure?url=http...


BUG=614562

Committed:
https://chromium.googlesource.com/infra/infra/+/f46208fd788b9e2951f6a8d10b8e4...
==========

[commit-bot: I haz the power, 2016-05-26 22:44:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/f46208fd788b9e2951f6a8d10b8e4...