Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2015643002: Add (optional) options to Run[Main]Application(). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan, dalesat
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add (optional) options to Run[Main]Application(). Using options, one can choose the message loop type in the "chromium" implementation. Convert a bunch more uses of ApplicationDelegate / ApplicationRunner[Chromium] (again, until I got bored). Many of the remaining cases require more refactoring. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/afa769287fd4fc7229377a7eb9e637b52a60ce63

Patch Set 1 #

Patch Set 2 : fix crash #

Patch Set 3 : doh #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -257 lines) Patch
M examples/apptest/example_service_application.h View 1 chunk +4 lines, -5 lines 0 comments Download
M examples/apptest/example_service_application.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M examples/audio_play_test/play_tone.cc View 5 chunks +13 lines, -16 lines 0 comments Download
M examples/audio_play_test/play_wav.cc View 6 chunks +14 lines, -17 lines 0 comments Download
M examples/authentication_demo/google_authentication_demo.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M examples/hello_mojo/hello_mojo_client.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M examples/hello_mojo/hello_mojo_server.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M examples/media_test/media_test.h View 3 chunks +5 lines, -3 lines 0 comments Download
M examples/media_test/media_test.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M examples/media_test/media_test_app.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M examples/native_run_app/native_run_app.cc View 3 chunks +10 lines, -13 lines 0 comments Download
M examples/wget/wget.cc View 3 chunks +8 lines, -12 lines 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/application/run_application.cc View 3 chunks +17 lines, -7 lines 0 comments Download
A mojo/application/run_application_options_chromium.h View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M mojo/public/cpp/application/lib/run_application.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/run_application.h View 2 chunks +18 lines, -3 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.h View 1 chunk +4 lines, -8 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_meta_factory_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_meta_factory_impl.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M services/authenticating_url_loader_interceptor/main.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M services/files/files_app.h View 1 chunk +4 lines, -6 lines 0 comments Download
M services/files/files_app.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/files/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/keyboard/linux/main.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M services/media/audio/audio_server_app.h View 2 chunks +5 lines, -7 lines 0 comments Download
M services/media/audio/audio_server_app.cc View 3 chunks +7 lines, -13 lines 1 comment Download
M services/native_support/main.cc View 1 4 chunks +20 lines, -11 lines 0 comments Download
M services/prediction/prediction_service_impl.h View 2 chunks +0 lines, -11 lines 0 comments Download
M services/prediction/prediction_service_impl.cc View 2 chunks +21 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
viettrungluu
4 years, 7 months ago (2016-05-25 19:56:34 UTC) #1
viettrungluu
ping
4 years, 7 months ago (2016-05-26 16:46:58 UTC) #2
vardhan
lgtm
4 years, 7 months ago (2016-05-26 17:55:05 UTC) #3
viettrungluu
Committed patchset #3 (id:40001) manually as afa769287fd4fc7229377a7eb9e637b52a60ce63 (presubmit successful).
4 years, 7 months ago (2016-05-26 17:57:21 UTC) #5
dalesat
4 years, 6 months ago (2016-05-31 22:15:26 UTC) #7
Message was sent while issue was closed.
I'll submit a CL to fix this.

https://codereview.chromium.org/2015643002/diff/40001/services/media/audio/au...
File services/media/audio/audio_server_app.cc (right):

https://codereview.chromium.org/2015643002/diff/40001/services/media/audio/au...
services/media/audio/audio_server_app.cc:19: void AudioServerApp::OnInitialize()
{}
No longer calls server_impl_.Initialize, which breaks the audio server

Powered by Google App Engine
This is Rietveld 408576698