Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012873003: More ApplicationDelegate/ApplicationRunner[Chromium] conversion. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work791_run_app_options
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

More ApplicationDelegate/ApplicationRunner[Chromium] conversion. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c103879240528467d54c93e51b61507dd56f193c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -139 lines) Patch
M examples/bank_app/bank.cc View 3 chunks +9 lines, -13 lines 0 comments Download
M examples/bank_app/customer.cc View 5 chunks +10 lines, -15 lines 0 comments Download
M examples/echo/echo_client.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M examples/echo/echo_client_sync.cc View 3 chunks +7 lines, -14 lines 0 comments Download
M examples/indirect_service/indirect_service_demo.cc View 5 chunks +15 lines, -19 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/http_server/http_server_app.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M services/http_server/http_server_factory_impl.h View 3 chunks +5 lines, -3 lines 0 comments Download
M services/http_server/http_server_factory_impl.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M services/http_server/http_server_impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M services/http_server/http_server_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.h View 1 chunk +5 lines, -8 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M shell/test/pingable_app.cc View 2 chunks +9 lines, -18 lines 0 comments Download
M shell/url_response_disk_cache_loader.h View 2 chunks +1 line, -3 lines 0 comments Download
M shell/url_response_disk_cache_loader.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 2015643002 Patch 40001

Messages

Total messages: 6 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/2015643002/ (kind of).
4 years, 7 months ago (2016-05-26 16:20:02 UTC) #1
viettrungluu
In case you missed this one....
4 years, 7 months ago (2016-05-26 22:10:31 UTC) #2
viettrungluu
ping
4 years, 6 months ago (2016-05-27 16:59:09 UTC) #3
vardhan
lgtm
4 years, 6 months ago (2016-05-27 18:01:05 UTC) #4
viettrungluu
4 years, 6 months ago (2016-05-27 18:05:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c103879240528467d54c93e51b61507dd56f193c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698