Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2015583003: Remove assorted unnecessary includes in core/layout/ (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews, blink-reviews-html_chromium.org, dshwang, eae+blinkwatch, fs, kouhei+svg_chromium.org, rwlbuis, krit, szager+layoutwatch_chromium.org, dglazkov+blink, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove assorted unnecessary includes in core/layout/ I was mainly looking at inclusions of LayoutObject-derived header files, but removed some others as well, while I was at it. BUG=614015 TBR=eae@chromium.org Committed: https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e Cr-Commit-Position: refs/heads/master@{#395993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -175 lines) Patch
M third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/BidiRun.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ClipRectsCache.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityController.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 2 chunks +1 line, -19 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 3 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFileUploadControl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutIFrame.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListBox.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMenuList.cpp View 1 chunk +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 5 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextCombine.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.h View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-25 21:27:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015583003/1
4 years, 7 months ago (2016-05-25 21:28:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 21:34:46 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 21:36:34 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7fe107c7078bc01376197e82a592b6a0a959749e
Cr-Commit-Position: refs/heads/master@{#395993}

Powered by Google App Engine
This is Rietveld 408576698