third_party/WebKit/Source/core/html/HTMLVideoElement.cpp - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

index d0fc1db2fb32f93dcf96079b55d90f74aa5dd0d7..48fe21d949ea4454d43c52c29c756a431e351f16 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

@@ -202,7 +202,7 @@ void HTMLVideoElement::paintCurrentFrame(SkCanvas* canvas, const IntRect& destRe

if (!paint || !SkXfermode::AsMode(paint->getXfermode(), &mode))

mode = SkXfermode::kSrcOver_Mode;

- // TODO(junov, philipj): crbug.com/456529 Pass the whole SkPaint instead of only alpha and xfermode

+ // TODO(junov, foolip): crbug.com/456529 Pass the whole SkPaint instead of only alpha and xfermode

webMediaPlayer()->paint(canvas, destRect, paint ? paint->getAlpha() : 0xFF, mode);

}