Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 195
196 void HTMLVideoElement::paintCurrentFrame(SkCanvas* canvas, const IntRect& destRe ct, const SkPaint* paint) const 196 void HTMLVideoElement::paintCurrentFrame(SkCanvas* canvas, const IntRect& destRe ct, const SkPaint* paint) const
197 { 197 {
198 if (!webMediaPlayer()) 198 if (!webMediaPlayer())
199 return; 199 return;
200 200
201 SkXfermode::Mode mode; 201 SkXfermode::Mode mode;
202 if (!paint || !SkXfermode::AsMode(paint->getXfermode(), &mode)) 202 if (!paint || !SkXfermode::AsMode(paint->getXfermode(), &mode))
203 mode = SkXfermode::kSrcOver_Mode; 203 mode = SkXfermode::kSrcOver_Mode;
204 204
205 // TODO(junov, philipj): crbug.com/456529 Pass the whole SkPaint instead of only alpha and xfermode 205 // TODO(junov, foolip): crbug.com/456529 Pass the whole SkPaint instead of o nly alpha and xfermode
206 webMediaPlayer()->paint(canvas, destRect, paint ? paint->getAlpha() : 0xFF, mode); 206 webMediaPlayer()->paint(canvas, destRect, paint ? paint->getAlpha() : 0xFF, mode);
207 } 207 }
208 208
209 bool HTMLVideoElement::copyVideoTextureToPlatformTexture(gpu::gles2::GLES2Interf ace* gl, GLuint texture, GLenum internalFormat, GLenum type, bool premultiplyAlp ha, bool flipY) 209 bool HTMLVideoElement::copyVideoTextureToPlatformTexture(gpu::gles2::GLES2Interf ace* gl, GLuint texture, GLenum internalFormat, GLenum type, bool premultiplyAlp ha, bool flipY)
210 { 210 {
211 if (!webMediaPlayer()) 211 if (!webMediaPlayer())
212 return false; 212 return false;
213 213
214 DCHECK(Extensions3DUtil::canUseCopyTextureCHROMIUM(GL_TEXTURE_2D, internalFo rmat, type, 0)); 214 DCHECK(Extensions3DUtil::canUseCopyTextureCHROMIUM(GL_TEXTURE_2D, internalFo rmat, type, 0));
215 return webMediaPlayer()->copyVideoTextureToPlatformTexture(gl, texture, inte rnalFormat, type, premultiplyAlpha, flipY); 215 return webMediaPlayer()->copyVideoTextureToPlatformTexture(gl, texture, inte rnalFormat, type, premultiplyAlpha, flipY);
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 return ScriptPromise(); 337 return ScriptPromise();
338 } 338 }
339 if (!sw || !sh) { 339 if (!sw || !sh) {
340 exceptionState.throwDOMException(IndexSizeError, String::format("The sou rce %s provided is 0.", sw ? "height" : "width")); 340 exceptionState.throwDOMException(IndexSizeError, String::format("The sou rce %s provided is 0.", sw ? "height" : "width"));
341 return ScriptPromise(); 341 return ScriptPromise();
342 } 342 }
343 return ImageBitmapSource::fulfillImageBitmap(scriptState, ImageBitmap::creat e(this, IntRect(sx, sy, sw, sh), eventTarget.toLocalDOMWindow()->document(), opt ions)); 343 return ImageBitmapSource::fulfillImageBitmap(scriptState, ImageBitmap::creat e(this, IntRect(sx, sy, sw, sh), eventTarget.toLocalDOMWindow()->document(), opt ions));
344 } 344 }
345 345
346 } // namespace blink 346 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextAreaElement.idl ('k') | third_party/WebKit/Source/core/html/ImageData.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698