third_party/WebKit/Source/core/editing/Selection.idl - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Selection.idl

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Selection.idl

diff --git a/third_party/WebKit/Source/core/editing/Selection.idl b/third_party/WebKit/Source/core/editing/Selection.idl

index b6f216f57fbbc88af72a2c255fff2c20e47083e1..2f8b61c191522fd5ababff02dda29e5bdd0c8bdb 100644

--- a/third_party/WebKit/Source/core/editing/Selection.idl

+++ b/third_party/WebKit/Source/core/editing/Selection.idl

@@ -51,7 +51,7 @@

[MeasureAs=SelectionCollapseToStart, RaisesException] void collapseToStart();

[MeasureAs=SelectionCollapseToEnd, RaisesException] void collapseToEnd();

[MeasureAs=SelectionExtend, RaisesException] void extend(Node node, optional long offset = 0);

- // TODO(philipj): The arguments should be anchorNode, anchorOffset,

+ // TODO(foolip): The arguments should be anchorNode, anchorOffset,

// focusNode and focusOffset, and none of them are nullable in the spec.

[MeasureAs=SelectionSetBaseAndExtent, RaisesException] void setBaseAndExtent(Node? baseNode, long baseOffset,

Node? extentNode, long extentOffset);