third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl - Issue 2015503002: Move TODO(philipj) to TODO(foolip)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl

Issue 2015503002: Move TODO(philipj) to TODO(foolip) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl

diff --git a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl

index b2a1872fac34235bd557d36f4e25fd7cfb4487d5..55f51411f4ffc8c8d8ce53aa1abe727728d31780 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl

+++ b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl

@@ -33,7 +33,7 @@ interface ShadowRoot : DocumentFragment {

[TreatNullAs=NullString, CustomElementCallbacks, RaisesException=Setter] attribute DOMString innerHTML;

[RuntimeEnabled=ShadowDOMV1] readonly attribute boolean delegatesFocus;

- // TODO(philipj): The spec does not override cloneNode() on the ShadowRoot

+ // TODO(foolip): The spec does not override cloneNode() on the ShadowRoot

// interface. Here, it's used to implement "Invoking the cloneNode() method

// on a ShadowRoot instance must always throw a DATA_CLONE_ERR exception" as

// Node.cloneNode() does not have [RaisesException].