Worker: Reorder function definitions of WorkerThread

Worker: Reorder function definitions of WorkerThread

This reorders function definitions to match with the order of their
declarations, and adds "OnWorkerThread" suffix to function names that must be
called on the worker thread. This is a mechanical change and should not change
any behavior of this class.

BUG=487050
Committed: https://crrev.com/a09afba4549756bfbf0ddd84a34d5c637abf73c8
Cr-Commit-Position: refs/heads/master@{#396133}

[nhiroki, 2016-05-25 01:20:50]

Description was changed from

==========
Worker: Make WorkerMicrotaskRunner a private inner class of WorkerThread

Mechanical changes only. This should not change any behavior.

This CL...

- makes WorkerMicrotaskRunner a private inner class of WorkerThread because the
  task runner is used only from WorkerThread and it needs to access a private
  function of WorkerThread,
- renames performShutdownTask() to performShutdown(), and
- reorders function definitions to match with the order of their declarations.

BUG=487050, 575532
==========

to

==========
Worker: Make WorkerMicrotaskRunner a private inner class of WorkerThread

Mechanical changes only. This should not change any behavior.

This CL...

- makes WorkerMicrotaskRunner a private inner class of WorkerThread because the
  task runner is used only from WorkerThread and it needs to access a private
  function of WorkerThread,
- moves prepareForShutdown() to a private section of WorkerThread,
- renames performShutdownTask() to performShutdown(), and
- reorders function definitions to match with the order of their declarations.

BUG=487050, 575532
==========

[nhiroki, 2016-05-25 01:40:01]

Description was changed from

==========
Worker: Make WorkerMicrotaskRunner a private inner class of WorkerThread

Mechanical changes only. This should not change any behavior.

This CL...

- makes WorkerMicrotaskRunner a private inner class of WorkerThread because the
  task runner is used only from WorkerThread and it needs to access a private
  function of WorkerThread,
- moves prepareForShutdown() to a private section of WorkerThread,
- renames performShutdownTask() to performShutdown(), and
- reorders function definitions to match with the order of their declarations.

BUG=487050, 575532
==========

to

==========
Worker: Reorder function definitions of WorkerThread for cleanup

Mechanical changes only. This should not change any behavior.

This CL reorders function definitions to match with the order of their
declarations.

BUG=487050, 575532
==========

[nhiroki, 2016-05-25 01:50:33]

Patchset #1 (id:1) has been deleted

[nhiroki, 2016-05-25 01:56:44]

Description was changed from

==========
Worker: Reorder function definitions of WorkerThread for cleanup

Mechanical changes only. This should not change any behavior.

This CL reorders function definitions to match with the order of their
declarations.

BUG=487050, 575532
==========

to

==========
Worker: Reorder function definitions of WorkerThread for cleanup

This reorders function definitions to match with the order of their
declarations. This is a mechanical change and should not change any behavior of
this class.

BUG=n/a
==========

[nhiroki, 2016-05-25 01:58:19]

Description was changed from

==========
Worker: Reorder function definitions of WorkerThread for cleanup

This reorders function definitions to match with the order of their
declarations. This is a mechanical change and should not change any behavior of
this class.

BUG=n/a
==========

to

==========
Worker: Reorder function definitions of WorkerThread

This reorders function definitions to match with the order of their
declarations. This is a mechanical change and should not change any behavior of
this class.

BUG=n/a
==========

[nhiroki, 2016-05-25 01:58:55]

nhiroki@chromium.org changed reviewers:
+ kinuko@chromium.org

[nhiroki, 2016-05-25 01:59:03]

ptal

[kinuko, 2016-05-25 07:11:22]

https://codereview.chromium.org/2015453002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/WorkerThread.h (right):

https://codereview.chromium.org/2015453002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/WorkerThread.h:136: void
performShutdown();
Could we put initialize and shutdown-related methods next to each other and put
performTask above or below them?  Also does it make sense to suffix these
methods with 'OnWorkerThread'?  E.g.

performTaskOnWorkerThread
initializeOnWorkerThread
prepareForShutdownOnWorkerThread
PerformShutdownOnWorkerThread

(For debugger task ones I'm neutral)

[nhiroki, 2016-05-25 23:53:29]

Thank you! Updated.

https://codereview.chromium.org/2015453002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/WorkerThread.h (right):

https://codereview.chromium.org/2015453002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/WorkerThread.h:136: void
performShutdown();
On 2016/05/25 07:11:22, kinuko wrote:
> Could we put initialize and shutdown-related methods next to each other and
put
> performTask above or below them?  Also does it make sense to suffix these
> methods with 'OnWorkerThread'?  E.g.
> 
> performTaskOnWorkerThread
> initializeOnWorkerThread
> prepareForShutdownOnWorkerThread
> PerformShutdownOnWorkerThread
> 
> (For debugger task ones I'm neutral)

Done. Reordered functions and added suffix to them.

[kinuko, 2016-05-26 01:13:24]

lgtm.

[nhiroki, 2016-05-26 01:19:15]

Description was changed from

==========
Worker: Reorder function definitions of WorkerThread

This reorders function definitions to match with the order of their
declarations. This is a mechanical change and should not change any behavior of
this class.

BUG=n/a
==========

to

==========
Worker: Reorder function definitions of WorkerThread

This reorders function definitions to match with the order of their
declarations, and adds "OnWorkerThread" suffix to function names that must be
called on the worker thread. This is a mechanical change and should not change
any behavior of this class.

BUG=487050
==========

[nhiroki, 2016-05-26 01:19:34]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2016-05-26 01:20:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2015453002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2015453002/60001

[commit-bot: I haz the power, 2016-05-26 06:16:58]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-26 06:18:27]

Description was changed from

==========
Worker: Reorder function definitions of WorkerThread

This reorders function definitions to match with the order of their
declarations, and adds "OnWorkerThread" suffix to function names that must be
called on the worker thread. This is a mechanical change and should not change
any behavior of this class.

BUG=487050
==========

to

==========
Worker: Reorder function definitions of WorkerThread

This reorders function definitions to match with the order of their
declarations, and adds "OnWorkerThread" suffix to function names that must be
called on the worker thread. This is a mechanical change and should not change
any behavior of this class.

BUG=487050

Committed: https://crrev.com/a09afba4549756bfbf0ddd84a34d5c637abf73c8
Cr-Commit-Position: refs/heads/master@{#396133}
==========

[commit-bot: I haz the power, 2016-05-26 06:18:28]

Patchset 3 (id:??) landed as
https://crrev.com/a09afba4549756bfbf0ddd84a34d5c637abf73c8
Cr-Commit-Position: refs/heads/master@{#396133}