Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: content/browser/media/android/browser_media_session_manager.cc

Issue 2015433003: Implement MediaMetadata artwork in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed nits, added TODOs Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/browser_media_session_manager.cc
diff --git a/content/browser/media/android/browser_media_session_manager.cc b/content/browser/media/android/browser_media_session_manager.cc
index a7e5fd5bbfa28e38fdeb8ac7290cacdf3c34f1ec..bd65792f7550a271dff18f97539ac4892a6cc7a3 100644
--- a/content/browser/media/android/browser_media_session_manager.cc
+++ b/content/browser/media/android/browser_media_session_manager.cc
@@ -4,6 +4,8 @@
#include "content/browser/media/android/browser_media_session_manager.h"
+#include "content/browser/media/session/media_session.h"
+#include "content/browser/web_contents/web_contents_impl.h"
#include "content/common/media/media_session_messages_android.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
@@ -37,13 +39,18 @@ void BrowserMediaSessionManager::OnSetMetadata(
insecure_metadata.artist.substr(0, MediaMetadata::kMaxIPCStringLength);
metadata.album =
insecure_metadata.album.substr(0, MediaMetadata::kMaxIPCStringLength);
+ // TODO(zqzhang): security checking for artwork?
palmer 2016/06/14 22:06:31 What is the nature of the artwork? To what extent
Zhiqiang Zhang (Slow) 2016/06/20 18:26:49 See the other reply for details.
+ metadata.artwork = insecure_metadata.artwork;
if (metadata != insecure_metadata) {
render_frame_host_->GetProcess()->ShutdownForBadMessage();
return;
}
- NOTIMPLEMENTED();
+ WebContentsImpl* contents = static_cast<WebContentsImpl*>(
+ WebContents::FromRenderFrameHost(render_frame_host_));
+ if (contents)
+ MediaSession::Get(contents)->SetMetadata(metadata);
}
int BrowserMediaSessionManager::GetRoutingID() const {

Powered by Google App Engine
This is Rietveld 408576698