content/browser/android/web_contents_observer_proxy.cc - Issue 2015433003: Implement MediaMetadata artwork in content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/web_contents_observer_proxy.cc

Issue 2015433003: Implement MediaMetadata artwork in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed nits, added TODOs Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/web_contents_observer_proxy.cc

diff --git a/content/browser/android/web_contents_observer_proxy.cc b/content/browser/android/web_contents_observer_proxy.cc

index dfa52cfb2112afb760c33379abdd1dc26136607c..7676e11118bb8710c8346edbb78571d999adcdbf 100644

--- a/content/browser/android/web_contents_observer_proxy.cc

+++ b/content/browser/android/web_contents_observer_proxy.cc

@@ -315,6 +315,10 @@ void WebContentsObserverProxy::MediaSessionStateChanged(

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj(java_observer_);

+ // TODO(zqzhang): the metadata is sent though JNI everytime the

+ // media session play/pause state changes. Need to find a way to

+ // seprate the state change and Metadata update.

ScopedJavaLocalRef<jobject> j_metadata =

MediaMetadataAndroid::CreateJavaObject(env, metadata);