Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 2015333002: Change parameters to GrPipelineBuilder's ctor (Closed)

Created:
4 years, 6 months ago by robertphillips
Modified:
4 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change parameters to GrPipelineBuilder's ctor This is just plumbing prep to remove the GrRenderTarget from the GrPipelineBuilder. Split out of: https://codereview.chromium.org/1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2015333002 Committed: https://skia.googlesource.com/skia/+/40ff8ed522d05a18a9ae92b2df96080677aed212

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -30 lines) Patch
M gm/constcolorprocessor.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 15 chunks +30 lines, -15 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 6 months ago (2016-05-27 18:46:58 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015333002/20001
4 years, 6 months ago (2016-05-27 18:51:41 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 19:07:18 UTC) #8
bsalomon
I'm not sure I get it but if this makes it easier to remove RT ...
4 years, 6 months ago (2016-05-27 20:27:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2015333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2015333002/20001
4 years, 6 months ago (2016-05-28 15:50:10 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 15:51:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/40ff8ed522d05a18a9ae92b2df96080677aed212

Powered by Google App Engine
This is Rietveld 408576698