Create ExecutableElementImpl.type lazily.

Create ExecutableElementImpl.type lazily.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/f0f51ed055c8a4595b5768c7923255b88c831842

[Paul Berry, 2016-05-27 17:04:50]

lgtm assuming issue below addressed

https://codereview.chromium.org/2015183003/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2015183003/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:7045:
_allTypeParameterTypes.addAll(allEnclosingTypeParameterTypes);
This order seems backwards.  Shouldn't we list outermost type parameters first?

[Brian Wilkerson, 2016-05-27 17:57:52]

lgtm

[scheglov, 2016-05-27 18:08:09]

Description was changed from

==========
Create ExecutableElementImpl.type lazily.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Create ExecutableElementImpl.type lazily.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/f0f51ed055c8a4595b5768c7923255b88c831842
==========

[scheglov, 2016-05-27 18:08:11]

Committed patchset #1 (id:1) manually as
f0f51ed055c8a4595b5768c7923255b88c831842 (presubmit successful).

[Paul Berry, 2016-05-31 15:13:05]

On 2016/05/27 18:08:11, scheglov wrote:
> Committed patchset #1 (id:1) manually as
> f0f51ed055c8a4595b5768c7923255b88c831842 (presubmit successful).

This seems to have caused a unit test failure.  Would you mind having a look?

Repro with: python tools/test.py -aia32 --checked -mrelease -t60
pkg/analyzer/test/src/summary/resynthesize_ast_test

Sample stack trace:
ERROR: AstInferredTypeTest | test_genericMethods_inferGenericFunctionReturnType
  Test failed: Caught type 'List<DartType>' is not a subtype of type
'Iterable<TypeParameterType>' of 'iterable' where
    List is from dart:core
    DartType is from package:analyzer/dart/element/type.dart
    Iterable is from dart:core
    TypeParameterType is from package:analyzer/dart/element/type.dart
  
  dart:core-patch/growable_array.dart 165                            List.addAll
  package:analyzer/src/dart/element/type.dart 778:17                
FunctionTypeImpl.instantiate
  package:analyzer/src/dart/element/type.dart 899:19                
FunctionTypeImpl._freeVariablesInFunctionType
  package:analyzer/src/dart/element/type.dart 654:7                 
FunctionTypeImpl.appendTo
  package:analyzer/src/dart/element/type.dart 2360:5                
TypeImpl.toString
  pkg/analyzer/test/src/task/strong/inferred_type_test.dart 1493:19 
AbstractResynthesizeTest&_AstResynthesizeTestMixin&InferredTypeMixin.test_genericMethods_inferGenericFunctionReturnType

[scheglov, 2016-05-31 15:34:53]

This https://codereview.chromium.org/2028443003 should fix the breakage.