Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2028443003: Create List<DartType> instead of List<TypeParameterType>. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create List<DartType> instead of List<TypeParameterType>. FunctionTypeImpl needs List<DartType>, so we cannot use more specific List<TypeParameterType> as is. In order to avoid conversion (and creating additional objects), we have to use List<DartType>. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1c69a71bf1765fda8af81a57aa36ccd78fefd952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 6 months ago (2016-05-31 15:34:15 UTC) #1
Paul Berry
lgtm
4 years, 6 months ago (2016-05-31 15:53:25 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 1c69a71bf1765fda8af81a57aa36ccd78fefd952 (presubmit successful).
4 years, 6 months ago (2016-05-31 16:14:27 UTC) #4
Brian Wilkerson
I don't understand why we would have anything other than a TypeParameterType in these lists, ...
4 years, 6 months ago (2016-05-31 16:18:05 UTC) #5
scheglov
4 years, 6 months ago (2016-05-31 16:52:24 UTC) #6
Message was sent while issue was closed.
On 2016/05/31 16:18:05, Brian Wilkerson wrote:
> I don't understand why we would have anything other than a TypeParameterType
in
> these lists, and this change isn't strong mode clean. We need to discuss this
> change.

Discussed offline.
The new fix https://codereview.chromium.org/2022993002 .

Powered by Google App Engine
This is Rietveld 408576698