Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: xfa/fxfa/parser/xfa_object.h

Issue 2015143005: Workaround dubious casting between CXFA_Object and void* in FXJSE (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Revert typecheck, actually fix code. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fxfa/fm2js/xfa_fm2jscontext.cpp ('k') | xfa/fxjse/class.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxfa/parser/xfa_object.h
diff --git a/xfa/fxfa/parser/xfa_object.h b/xfa/fxfa/parser/xfa_object.h
index 28d4712e462291c698f0276f2e55c8e89a7fd487..8fc074c08fb670004533f31a4f32b90e196c7903 100644
--- a/xfa/fxfa/parser/xfa_object.h
+++ b/xfa/fxfa/parser/xfa_object.h
@@ -41,9 +41,12 @@ enum XFA_OBJECTTYPE {
XFA_NODEFLAG_UnusedNode = 0x08000,
XFA_NODEFLAG_LayoutGeneratedNode = 0x10000,
};
+
class CXFA_Object {
public:
CXFA_Object(CXFA_Document* pDocument, uint32_t uFlags);
+ virtual ~CXFA_Object() {}
+
CXFA_Document* GetDocument() const { return m_pDocument; }
uint32_t GetFlag() const { return m_uFlags; }
XFA_OBJECTTYPE GetObjectType() const {
@@ -590,7 +593,7 @@ class CXFA_Node : public CXFA_Object {
protected:
CXFA_Node(CXFA_Document* pDoc, uint16_t ePacket, XFA_ELEMENT eElement);
- ~CXFA_Node();
+ ~CXFA_Node() override;
friend class CXFA_Document;
CXFA_Node* Deprecated_GetPrevSibling();
FX_BOOL SetValue(XFA_ATTRIBUTE eAttr,
@@ -669,7 +672,7 @@ class CXFA_ThisProxy : public CXFA_Object {
m_pThisNode = pThisNode;
m_pScriptNode = pScriptNode;
}
- virtual ~CXFA_ThisProxy() {}
+ ~CXFA_ThisProxy() override {}
CXFA_Node* GetThisNode() { return m_pThisNode; }
CXFA_Node* GetScriptNode() { return m_pScriptNode; }
« no previous file with comments | « xfa/fxfa/fm2js/xfa_fm2jscontext.cpp ('k') | xfa/fxjse/class.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698