xfa/fxfa/fm2js/xfa_fm2jscontext.cpp - Issue 2015143005: Workaround dubious casting between CXFA_Object and void* in FXJSE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/fm2js/xfa_fm2jscontext.cpp

Issue 2015143005: Workaround dubious casting between CXFA_Object and void* in FXJSE (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Revert typecheck, actually fix code. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/fm2js/xfa_fm2jscontext.cpp

diff --git a/xfa/fxfa/fm2js/xfa_fm2jscontext.cpp b/xfa/fxfa/fm2js/xfa_fm2jscontext.cpp

index 40d8bcf5f42bbd519e8a863cb717ffbb157cee9f..2c8a362807b436910c27a2eedc83cb820ae01903 100644

--- a/xfa/fxfa/fm2js/xfa_fm2jscontext.cpp

+++ b/xfa/fxfa/fm2js/xfa_fm2jscontext.cpp

@@ -3347,7 +3347,8 @@ void CXFA_FM2JSContext::Eval(CFXJSE_Value* pThis,

XFA_FM2JS_Translate(

CFX_WideString::FromUTF8(utf8ScriptString.AsStringC()).AsStringC(),

wsJavaScriptBuf, wsError);

- CFXJSE_Context* pContext = FXJSE_Context_Create(pIsolate);

+ CFXJSE_Context* pContext =

+ FXJSE_Context_Create(pIsolate, nullptr, nullptr);

CFXJSE_Value* returnValue = FXJSE_Value_Create(pIsolate);

javaScript = wsJavaScriptBuf.AsStringC();

FXJSE_ExecuteScript(

« no previous file with comments | « xfa.gyp ('k') | xfa/fxfa/parser/xfa_object.h » ('j') | no next file with comments »