Issue 2015083004: Use initialized canvas to create network icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2015083004: Use initialized canvas to create network icons. (Closed)

Created:
4 years, 6 months ago by oshima

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Use initialized canvas to create network icons. Remove rarely used ctor. BUG=611616 Review-Url: https://codereview.chromium.org/2016833002 Cr-Commit-Position: refs/heads/master@{#396326} (cherry picked from commit 07b5fad29dd278dee342363c7562bcec1fd729de) Committed: https://chromium.googlesource.com/chromium/src/+/64bf7b0d391ee2670c5239dfb9ac867d180fed05

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -19 lines)			Patch
M	ui/chromeos/network/network_icon.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	ui/gfx/canvas.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/gfx/canvas.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download

Total messages: 3 (2 generated)

oshima

4 years, 6 months ago (2016-05-27 23:27:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
64bf7b0d391ee2670c5239dfb9ac867d180fed05.