Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2016833002: Use initialized canvas to create network icons. (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use initialized canvas to create network icons. Remove rarely used ctor. BUG=611616 Committed: https://crrev.com/07b5fad29dd278dee342363c7562bcec1fd729de Cr-Commit-Position: refs/heads/master@{#396326}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M ui/chromeos/network/network_icon.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ui/gfx/canvas.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gfx/canvas.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016833002/1
4 years, 7 months ago (2016-05-26 20:02:38 UTC) #2
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-26 20:44:10 UTC) #3
oshima
4 years, 7 months ago (2016-05-26 21:58:30 UTC) #11
oshima
4 years, 7 months ago (2016-05-26 21:58:32 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016833002/60001
4 years, 7 months ago (2016-05-26 21:59:07 UTC) #13
danakj
LGTM
4 years, 7 months ago (2016-05-26 22:16:50 UTC) #14
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-26 22:18:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016833002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016833002/60001
4 years, 7 months ago (2016-05-26 22:19:39 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 7 months ago (2016-05-27 00:09:34 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 00:11:40 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07b5fad29dd278dee342363c7562bcec1fd729de
Cr-Commit-Position: refs/heads/master@{#396326}

Powered by Google App Engine
This is Rietveld 408576698