Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: third_party/WebKit/Source/core/frame/FrameOwner.h

Issue 2015003002: Disallow local/remote checks on subclasses of Frame, FrameOwner and DOMWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/Frame.h ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameOwner.h
diff --git a/third_party/WebKit/Source/core/frame/FrameOwner.h b/third_party/WebKit/Source/core/frame/FrameOwner.h
index d19b837910ace798ee062bd8e9c7f2609b3a37e0..af018883fc385c0fecf62a37fd8660c768153209 100644
--- a/third_party/WebKit/Source/core/frame/FrameOwner.h
+++ b/third_party/WebKit/Source/core/frame/FrameOwner.h
@@ -52,8 +52,6 @@ public:
DEFINE_INLINE_VIRTUAL_TRACE() { FrameOwner::trace(visitor); }
// FrameOwner overrides:
- bool isLocal() const override { return false; }
- bool isRemote() const override { return false; }
void setContentFrame(Frame&) override { }
void clearContentFrame() override { }
SandboxFlags getSandboxFlags() const override { return SandboxNone; }
@@ -63,6 +61,12 @@ public:
int marginWidth() const override { return -1; }
int marginHeight() const override { return -1; }
bool allowFullscreen() const override { return false; }
+
+private:
+ // Intentionally private to prevent redundant checks when the type is
+ // already DummyFrameOwner.
+ bool isLocal() const override { return false; }
+ bool isRemote() const override { return false; }
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/frame/Frame.h ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698