Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2014933002: Move DeviceMonitorLinux to //device/core. (Closed)

Created:
4 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
Zachary Kuznia, juncai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DeviceMonitorLinux to //device/core. This code will be shared by HidServiceLinux and UsbServiceLinux so it needs to be in the shared //device/core component. Sharing the service introduces an issue with destruction order that is resolved by adding a WillDestroyMonitorMessageLoop() method to its Observer interface. BUG=422562 Committed: https://crrev.com/57b6ff447084f1b0040557436d0f55c1e152626c Cr-Commit-Position: refs/heads/master@{#396318}

Patch Set 1 #

Patch Set 2 : Fix //components/pairing build. #

Total comments: 1

Patch Set 3 : Added comment for boolean parameter. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -284 lines) Patch
M components/pairing/bluetooth_host_pairing_controller.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/core/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download
M device/core/core.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
A + device/core/device_monitor_linux.h View 3 chunks +5 lines, -3 lines 0 comments Download
A + device/core/device_monitor_linux.cc View 1 2 4 chunks +9 lines, -18 lines 0 comments Download
M device/hid/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D device/hid/device_monitor_linux.h View 1 chunk +0 lines, -75 lines 0 comments Download
D device/hid/device_monitor_linux.cc View 1 chunk +0 lines, -151 lines 0 comments Download
M device/hid/hid.gyp View 2 chunks +1 line, -3 lines 0 comments Download
M device/hid/hid_service_linux.cc View 4 chunks +3 lines, -10 lines 0 comments Download
M device/hid/input_service_linux.h View 4 chunks +2 lines, -9 lines 0 comments Download
M device/hid/input_service_linux.cc View 5 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Reilly Grant (use Gerrit)
Fix //components/pairing build.
4 years, 7 months ago (2016-05-26 18:24:25 UTC) #1
Reilly Grant (use Gerrit)
juncai@, please review //device. zork@, please review //components/pairing.
4 years, 7 months ago (2016-05-26 18:24:45 UTC) #3
juncai
LGTM with nit. https://codereview.chromium.org/2014933002/diff/20001/device/core/device_monitor_linux.cc File device/core/device_monitor_linux.cc (right): https://codereview.chromium.org/2014933002/diff/20001/device/core/device_monitor_linux.cc#newcode56 device/core/device_monitor_linux.cc:56: monitor_fd_, true, base::MessageLoopForIO::WATCH_READ, nit: added comment ...
4 years, 7 months ago (2016-05-26 18:43:52 UTC) #4
Reilly Grant (use Gerrit)
Added comment for boolean parameter.
4 years, 7 months ago (2016-05-26 18:51:36 UTC) #5
Zachary Kuznia
lgtm
4 years, 7 months ago (2016-05-26 21:08:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014933002/40001
4 years, 6 months ago (2016-05-26 22:29:48 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-26 23:35:02 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 23:36:57 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/57b6ff447084f1b0040557436d0f55c1e152626c
Cr-Commit-Position: refs/heads/master@{#396318}

Powered by Google App Engine
This is Rietveld 408576698