Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1676)

Side by Side Diff: device/hid/hid_service_linux.cc

Issue 2014933002: Move DeviceMonitorLinux to //device/core. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comment for boolean parameter. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/hid/hid.gyp ('k') | device/hid/input_service_linux.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/hid/hid_service_linux.h" 5 #include "device/hid/hid_service_linux.h"
6 6
7 #include <fcntl.h> 7 #include <fcntl.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <limits> 10 #include <limits>
11 #include <memory> 11 #include <memory>
12 #include <string> 12 #include <string>
13 #include <utility> 13 #include <utility>
14 14
15 #include "base/bind.h" 15 #include "base/bind.h"
16 #include "base/files/file.h" 16 #include "base/files/file.h"
17 #include "base/files/file_path.h" 17 #include "base/files/file_path.h"
18 #include "base/files/file_util.h" 18 #include "base/files/file_util.h"
19 #include "base/location.h" 19 #include "base/location.h"
20 #include "base/macros.h" 20 #include "base/macros.h"
21 #include "base/scoped_observer.h" 21 #include "base/scoped_observer.h"
22 #include "base/strings/string_number_conversions.h" 22 #include "base/strings/string_number_conversions.h"
23 #include "base/strings/string_split.h" 23 #include "base/strings/string_split.h"
24 #include "base/threading/thread_restrictions.h" 24 #include "base/threading/thread_restrictions.h"
25 #include "base/threading/thread_task_runner_handle.h" 25 #include "base/threading/thread_task_runner_handle.h"
26 #include "build/build_config.h" 26 #include "build/build_config.h"
27 #include "components/device_event_log/device_event_log.h" 27 #include "components/device_event_log/device_event_log.h"
28 #include "device/hid/device_monitor_linux.h" 28 #include "device/core/device_monitor_linux.h"
29 #include "device/hid/hid_connection_linux.h" 29 #include "device/hid/hid_connection_linux.h"
30 #include "device/hid/hid_device_info_linux.h" 30 #include "device/hid/hid_device_info_linux.h"
31 #include "device/udev_linux/scoped_udev.h" 31 #include "device/udev_linux/scoped_udev.h"
32 32
33 #if defined(OS_CHROMEOS) 33 #if defined(OS_CHROMEOS)
34 #include "base/sys_info.h" 34 #include "base/sys_info.h"
35 #include "chromeos/dbus/dbus_thread_manager.h" 35 #include "chromeos/dbus/dbus_thread_manager.h"
36 #include "chromeos/dbus/permission_broker_client.h" 36 #include "chromeos/dbus/permission_broker_client.h"
37 #endif // defined(OS_CHROMEOS) 37 #endif // defined(OS_CHROMEOS)
38 38
(...skipping 20 matching lines...) Expand all
59 file_task_runner(file_task_runner) {} 59 file_task_runner(file_task_runner) {}
60 ~ConnectParams() {} 60 ~ConnectParams() {}
61 61
62 scoped_refptr<HidDeviceInfoLinux> device_info; 62 scoped_refptr<HidDeviceInfoLinux> device_info;
63 ConnectCallback callback; 63 ConnectCallback callback;
64 scoped_refptr<base::SingleThreadTaskRunner> task_runner; 64 scoped_refptr<base::SingleThreadTaskRunner> task_runner;
65 scoped_refptr<base::SingleThreadTaskRunner> file_task_runner; 65 scoped_refptr<base::SingleThreadTaskRunner> file_task_runner;
66 base::File device_file; 66 base::File device_file;
67 }; 67 };
68 68
69 class HidServiceLinux::FileThreadHelper 69 class HidServiceLinux::FileThreadHelper : public DeviceMonitorLinux::Observer {
70 : public DeviceMonitorLinux::Observer,
71 public base::MessageLoop::DestructionObserver {
72 public: 70 public:
73 FileThreadHelper(base::WeakPtr<HidServiceLinux> service, 71 FileThreadHelper(base::WeakPtr<HidServiceLinux> service,
74 scoped_refptr<base::SingleThreadTaskRunner> task_runner) 72 scoped_refptr<base::SingleThreadTaskRunner> task_runner)
75 : observer_(this), service_(service), task_runner_(task_runner) {} 73 : observer_(this), service_(service), task_runner_(task_runner) {}
76 74
77 ~FileThreadHelper() override { 75 ~FileThreadHelper() override {
78 DCHECK(thread_checker_.CalledOnValidThread()); 76 DCHECK(thread_checker_.CalledOnValidThread());
79 base::MessageLoop::current()->RemoveDestructionObserver(this);
80 } 77 }
81 78
82 static void Start(std::unique_ptr<FileThreadHelper> self) { 79 static void Start(std::unique_ptr<FileThreadHelper> self) {
83 base::ThreadRestrictions::AssertIOAllowed(); 80 base::ThreadRestrictions::AssertIOAllowed();
84 self->thread_checker_.DetachFromThread(); 81 self->thread_checker_.DetachFromThread();
85 // |self| must be added as a destruction observer first so that it will be
86 // notified before DeviceMonitorLinux.
87 base::MessageLoop::current()->AddDestructionObserver(self.get());
88 82
89 DeviceMonitorLinux* monitor = DeviceMonitorLinux::GetInstance(); 83 DeviceMonitorLinux* monitor = DeviceMonitorLinux::GetInstance();
90 self->observer_.Add(monitor); 84 self->observer_.Add(monitor);
91 monitor->Enumerate(base::Bind(&FileThreadHelper::OnDeviceAdded, 85 monitor->Enumerate(base::Bind(&FileThreadHelper::OnDeviceAdded,
92 base::Unretained(self.get()))); 86 base::Unretained(self.get())));
93 self->task_runner_->PostTask( 87 self->task_runner_->PostTask(
94 FROM_HERE, 88 FROM_HERE,
95 base::Bind(&HidServiceLinux::FirstEnumerationComplete, self->service_)); 89 base::Bind(&HidServiceLinux::FirstEnumerationComplete, self->service_));
96 90
97 // |self| is now owned by the current message loop. 91 // |self| is now owned by the current message loop.
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 void OnDeviceRemoved(udev_device* device) override { 180 void OnDeviceRemoved(udev_device* device) override {
187 DCHECK(thread_checker_.CalledOnValidThread()); 181 DCHECK(thread_checker_.CalledOnValidThread());
188 const char* device_path = udev_device_get_syspath(device); 182 const char* device_path = udev_device_get_syspath(device);
189 if (device_path) { 183 if (device_path) {
190 task_runner_->PostTask( 184 task_runner_->PostTask(
191 FROM_HERE, base::Bind(&HidServiceLinux::RemoveDevice, service_, 185 FROM_HERE, base::Bind(&HidServiceLinux::RemoveDevice, service_,
192 std::string(device_path))); 186 std::string(device_path)));
193 } 187 }
194 } 188 }
195 189
196 // base::MessageLoop::DestructionObserver: 190 void WillDestroyMonitorMessageLoop() override {
197 void WillDestroyCurrentMessageLoop() override {
198 DCHECK(thread_checker_.CalledOnValidThread()); 191 DCHECK(thread_checker_.CalledOnValidThread());
199 delete this; 192 delete this;
200 } 193 }
201 194
202 base::ThreadChecker thread_checker_; 195 base::ThreadChecker thread_checker_;
203 ScopedObserver<DeviceMonitorLinux, DeviceMonitorLinux::Observer> observer_; 196 ScopedObserver<DeviceMonitorLinux, DeviceMonitorLinux::Observer> observer_;
204 197
205 // This weak pointer is only valid when checked on this task runner. 198 // This weak pointer is only valid when checked on this task runner.
206 base::WeakPtr<HidServiceLinux> service_; 199 base::WeakPtr<HidServiceLinux> service_;
207 scoped_refptr<base::SingleThreadTaskRunner> task_runner_; 200 scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 337
345 // static 338 // static
346 void HidServiceLinux::CreateConnection(std::unique_ptr<ConnectParams> params) { 339 void HidServiceLinux::CreateConnection(std::unique_ptr<ConnectParams> params) {
347 DCHECK(params->device_file.IsValid()); 340 DCHECK(params->device_file.IsValid());
348 params->callback.Run(make_scoped_refptr(new HidConnectionLinux( 341 params->callback.Run(make_scoped_refptr(new HidConnectionLinux(
349 params->device_info, std::move(params->device_file), 342 params->device_info, std::move(params->device_file),
350 params->file_task_runner))); 343 params->file_task_runner)));
351 } 344 }
352 345
353 } // namespace device 346 } // namespace device
OLDNEW
« no previous file with comments | « device/hid/hid.gyp ('k') | device/hid/input_service_linux.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698