Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2014913002: Tree-shaker: drop imports/exports in a way that doesn't break the vm-service. (Closed)

Created:
4 years, 7 months ago by rmacnak
Modified:
4 years, 7 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tree-shaker: drop imports/exports in a way that doesn't break the vm-service. BUG=http://dartbug.com/26550 R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/e3f5760f6647bdb54d11819c5087087a823a4f8a

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M runtime/vm/object.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
rmacnak
4 years, 7 months ago (2016-05-26 18:06:31 UTC) #5
hausner
lgtm
4 years, 7 months ago (2016-05-26 18:22:00 UTC) #6
rmacnak
4 years, 7 months ago (2016-05-26 18:29:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e3f5760f6647bdb54d11819c5087087a823a4f8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698